NEW98863
[WK2] Show a "Press ESC to leave full-screen mode" warning when entering fullscreen 
https://bugs.webkit.org/show_bug.cgi?id=98863
Summary [WK2] Show a "Press ESC to leave full-screen mode" warning when entering full...
Jer Noble
Reported 2012-10-09 23:14:08 PDT
Show a "Press ESC to leave full-screen mode" warning when entering fullscreen
Attachments
Patch (26.09 KB, patch)
2012-10-10 01:09 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (26.53 KB, patch)
2012-10-10 09:47 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (32.72 KB, patch)
2012-10-11 12:39 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (10.17 KB, patch)
2012-11-14 19:09 PST, Jer Noble 		darin: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2012-10-10 00:52:10 PDT
<rdar://problem/12459549>
Jer Noble
Comment 2 2012-10-10 01:09:41 PDT
Created attachment 167951 [details] Patch
Jer Noble
Comment 3 2012-10-10 09:47:46 PDT
Created attachment 168019 [details] Patch Rebased
Jer Noble
Comment 4 2012-10-11 12:39:49 PDT
Created attachment 168261 [details] Patch Disable the full screen warning when a <video> element is the full screen element.
Jer Noble
Comment 5 2012-11-14 19:09:34 PST
Created attachment 174320 [details] Patch For ease of reviewing, this patch has been split into 3 parts, including bug #102315, and bug #102317. Additionally, those bugs now depend on bug #102300 and bug #102299.
Early Warning System Bot
Comment 6 2012-11-14 19:14:01 PST
Comment on attachment 174320 [details] Patch Attachment 174320 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14844311
EFL EWS Bot
Comment 7 2012-11-14 19:17:22 PST
Comment on attachment 174320 [details] Patch Attachment 174320 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14857019
Build Bot
Comment 8 2012-11-14 22:43:41 PST
Comment on attachment 174320 [details] Patch Attachment 174320 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14848235
Build Bot
Comment 9 2012-11-15 11:07:00 PST
Comment on attachment 174320 [details] Patch Attachment 174320 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14837868
Antonio Gomes
Comment 10 2012-11-16 11:18:12 PST
Comment on attachment 174320 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174320&action=review > Source/WebKit2/ChangeLog:11 > + if the full screened element is is?
Jer Noble
Comment 11 2012-11-16 11:25:38 PST
(In reply to comment #10) > (From update of attachment 174320 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174320&action=review > > > Source/WebKit2/ChangeLog:11 > > + if the full screened element is > > is? I fell asleep halfway through writing this ChangeLog, apparently. :) I'll update this to read "Only present the warning if the full screened element is not a media element."
Alexey Proskuryakov
Comment 12 2013-10-03 11:53:46 PDT
Is this still necessary?
Anders Carlsson
Comment 13 2014-02-05 11:06:35 PST
Comment on attachment 174320 [details] Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
Jer Noble
Comment 14 2014-02-05 11:13:46 PST
Comment on attachment 174320 [details] Patch Yep, still relevant.
Note You need to log in before you can comment on or make changes to this bug.