WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
102300
Add a new shared class WebCoreFullScreenPlaceholderView, for use in WebKit and WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=102300
Summary
Add a new shared class WebCoreFullScreenPlaceholderView, for use in WebKit an...
Jer Noble
Reported
2012-11-14 16:41:39 PST
Add a new shared class WebCoreFullScreenPlaceholderView, for use in WebKit and WebKit2.
Attachments
Patch
(14.46 KB, patch)
2012-11-14 16:59 PST
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Patch
(15.12 KB, patch)
2012-11-26 15:49 PST
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Patch
(14.84 KB, patch)
2012-11-27 14:32 PST
,
Jer Noble
andersca
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Jer Noble
Comment 1
2012-11-14 16:59:50 PST
Created
attachment 174292
[details]
Patch
Sam Weinig
Comment 2
2012-11-24 18:40:56 PST
Comment on
attachment 174292
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=174292&action=review
> Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:84 > + [_exitWarning.get() setHidden:!visible]; > + if (visible) { > + CIFilter* filter = [CIFilter filterWithName:@"CIFalseColor" keysAndValues: > + @"inputColor0", [CIColor colorWithRed:0 green:0 blue:0], > + @"inputColor1", [CIColor colorWithRed:.9 green:.9 blue:.9], > + nil]; > + [[self layer] setCompositingFilter:filter]; > + } else > + [[self layer] setCompositingFilter:nil];
We should try to do this without using CoreImage. CoreImage doesn't play nice with our layer hosting strategy.
Jer Noble
Comment 3
2012-11-26 15:49:20 PST
Created
attachment 176098
[details]
Patch Removed the CIFilter, replacing it with a simple greyscale overlay layer.
Jer Noble
Comment 4
2012-11-27 14:32:00 PST
Created
attachment 176340
[details]
Patch
Anders Carlsson
Comment 5
2012-11-27 15:22:22 PST
Comment on
attachment 176340
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=176340&action=review
> Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:55 > + warningFrame.origin = NSMakePoint( > + (frameRect.size.width - warningFrame.size.width) / 2, > + (frameRect.size.height - warningFrame.size.height) / 2);
Remove the newlines here.
Jer Noble
Comment 6
2012-11-27 16:39:25 PST
Committed
r135941
: <
http://trac.webkit.org/changeset/135941
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug