Bug 102300 - Add a new shared class WebCoreFullScreenPlaceholderView, for use in WebKit and WebKit2.
Summary: Add a new shared class WebCoreFullScreenPlaceholderView, for use in WebKit an...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on: 102299
Blocks: 102315 100025
  Show dependency treegraph
 
Reported: 2012-11-14 16:41 PST by Jer Noble
Modified: 2012-11-27 16:39 PST (History)
0 users

See Also:


Attachments
Patch (14.46 KB, patch)
2012-11-14 16:59 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (15.12 KB, patch)
2012-11-26 15:49 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (14.84 KB, patch)
2012-11-27 14:32 PST, Jer Noble
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2012-11-14 16:41:39 PST
Add a new shared class WebCoreFullScreenPlaceholderView, for use in WebKit and WebKit2.
Comment 1 Jer Noble 2012-11-14 16:59:50 PST
Created attachment 174292 [details]
Patch
Comment 2 Sam Weinig 2012-11-24 18:40:56 PST
Comment on attachment 174292 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174292&action=review

> Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:84
> +    [_exitWarning.get() setHidden:!visible];
> +    if (visible) {
> +        CIFilter* filter = [CIFilter filterWithName:@"CIFalseColor" keysAndValues:
> +                            @"inputColor0", [CIColor colorWithRed:0 green:0 blue:0],
> +                            @"inputColor1", [CIColor colorWithRed:.9 green:.9 blue:.9],
> +                            nil];
> +        [[self layer] setCompositingFilter:filter];
> +    } else
> +        [[self layer] setCompositingFilter:nil];

We should try to do this without using CoreImage.  CoreImage doesn't play nice with our layer hosting strategy.
Comment 3 Jer Noble 2012-11-26 15:49:20 PST
Created attachment 176098 [details]
Patch

Removed the CIFilter, replacing it with a simple greyscale overlay layer.
Comment 4 Jer Noble 2012-11-27 14:32:00 PST
Created attachment 176340 [details]
Patch
Comment 5 Anders Carlsson 2012-11-27 15:22:22 PST
Comment on attachment 176340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176340&action=review

> Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:55
> +    warningFrame.origin = NSMakePoint(
> +                                      (frameRect.size.width - warningFrame.size.width) / 2,
> +                                      (frameRect.size.height - warningFrame.size.height) / 2);

Remove the newlines here.
Comment 6 Jer Noble 2012-11-27 16:39:25 PST
Committed r135941: <http://trac.webkit.org/changeset/135941>