Bug 98726 – [EFL][EWebLauncher] Add encoding detector option.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Kangil Han]

We need this to test WebCore's encoding detector functionality.

[Kangil Han]

Created attachment 167698 [details]
patch

[Ryuan Choi]

(In reply to comment #1)
> Created an attachment (id=167698) [details]
> patch

LGTM

[Gyuyoung Kim]

Comment on attachment 167698 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167698&action=review

> Tools/EWebLauncher/main.c:151
> +    Eina_Bool enableEncodingDetector;

Alphabetical order ?

> Tools/EWebLauncher/main.c:917
> +    userArgs->enableEncodingDetector = EINA_FALSE;

ditto ?

> Tools/EWebLauncher/main.c:931
> +        ECORE_GETOPT_VALUE_BOOL(userArgs->enableEncodingDetector),

ditto ?

[Kangil Han]

Created attachment 167735 [details]
patch

Done~

[Kenneth Rohde Christiansen]

Comment on attachment 167735 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167735&action=review

> Tools/ChangeLog:10
> +
> +        Added an option to test WebCore's encoding detector functionality on EWebLauncher.
> +        With this patch, EWebLauncher would display text correctly even if web page wouldn't specify charset information.
> +

Why isnt this default? and what about WebKit2, isn't that our target?

[Kangil Han]

(In reply to comment #5)
> Why isnt this default?

Would you like to enable this functionality by default?

> and what about WebKit2, isn't that our target?

Yuni Jeong has prepared to create a patch for adding a setting API to enable encoding detector. I will follow up after her in MiniBrowser. :-)

[Kenneth Rohde Christiansen]

(In reply to comment #6)
> (In reply to comment #5)
> > Why isnt this default?
> 
> Would you like to enable this functionality by default?

Is there any reason not to? When don't you want this?

[Ryuan Choi]

(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > Why isnt this default?
> > 
> > Would you like to enable this functionality by default?
> 
> Is there any reason not to? When don't you want this?

In Bug 61744, it was disabled to pass dom/xhtml/level3/core/documentgetinputencoding01.xhtml

[Kangil Han]

(In reply to comment #8)
> In Bug 61744, it was disabled to pass dom/xhtml/level3/core/documentgetinputencoding01.xhtml

Thanks for this information. I didn't know that. :-)

[Gyuyoung Kim]

(In reply to comment #9)
> (In reply to comment #8)
> > In Bug 61744, it was disabled to pass dom/xhtml/level3/core/documentgetinputencoding01.xhtml
> 
> Thanks for this information. I didn't know that. :-)

Ok, let's decide to land this patch according to Bug 61744 direction.

[Kangil Han]

(In reply to comment #7)
> Is there any reason not to? When don't you want this?

Here is interesting result of layout test when enable/disable encoding auto detection by default. If we enable encoding auto detection, then will have additional 125 failed test cases.

FYI, this test has been done on my desktop, Ubuntu 12.04 64 bit debug build.

Given circumstance, let's use encoding detector as an optional functionality. :)

p.s. It seems other ports off this as default.

[WebKit Review Bot]

Comment on attachment 167735 [details]
patch

Clearing flags on attachment: 167735

Committed r131312: <http://trac.webkit.org/changeset/131312>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.