Bug 61744 – [efl] Do not enable the encoding detector by default.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Raphael Kubo da Costa (:rakuco)]

[efl] Do not enable the encoding detector by default.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 95368 [details]
Patch

[Lucas De Marchi]

Comment on attachment 95368 [details]
Patch

Out of curiosity, what tests fail with this turned on?

Aren't they missing the encoding setting if they rely on them?

[Raphael Kubo da Costa (:rakuco)]

In this specific case, that's dom/xhtml/level3/core/documentgetinputencoding01.xhtml, which checks exactly for this.

[Brent Fulgham]

Comment on attachment 95368 [details]
Patch

Looks good to me.  When landing, please update the ChangeLog to include the helpful information that this code is exercised by the "dom/xhtml/level3/core/documentgetinputencoding01.xhtml" test.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 95904 [details]
Same patch, more detailed ChangeLog

Sorry for the delay; this is the new patch explicitly mentioning dom/xhtml/level3/core/documentgetinputencoding01.xhtml.

[WebKit Review Bot]

Attachment 95904 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1

Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Raphael Kubo da Costa (:rakuco)]

Huh? Is there a way to re-run the style bot?

[Lucas De Marchi]

(In reply to comment #7)
> Huh? Is there a way to re-run the style bot?

I think that you need to upload it again.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 95917 [details]
Same patch, more detailed ChangeLog, take #2

[WebKit Review Bot]

Attachment 95917 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1

Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gyuyoung Kim]

It seems there is no style errors. So, you need to update this patch again.

[Lucas De Marchi]

Committed r88515: <http://trac.webkit.org/changeset/88515>

[Eric Seidel (no email)]

Comment on attachment 95917 [details]
Same patch, more detailed ChangeLog, take #2

Cleared review? from attachment 95917 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).

[Kenneth Rohde Christiansen]

Comment on attachment 95917 [details]
Same patch, more detailed ChangeLog, take #2

View in context: https://bugs.webkit.org/attachment.cgi?id=95917&action=review

> a/Source/WebKit/efl/ChangeLog:9
> +        This should match the behaviour of other ports more closely, and makes
> +        at least dom/xhtml/level3/core/documentgetinputencoding01.xhtml pass.

So if all browsers enable (or should enable) it anyway, what is the point? Isn't this a bug in the decoding detector instead?