Bug 61744 - [efl] Do not enable the encoding detector by default.
Summary: [efl] Do not enable the encoding detector by default.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 98726
  Show dependency tree / graph
 
Reported: 2011-05-30 13:43 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2012-10-09 05:24 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.52 KB, patch)
2011-05-30 13:53 PDT, Raphael Kubo da Costa (:rakuco) 		bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff
Same patch, more detailed ChangeLog (1.21 KB, patch)
2011-06-03 06:06 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Same patch, more detailed ChangeLog, take #2 (1.22 KB, patch)
2011-06-03 08:42 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2011-05-30 13:43:23 PDT 
[efl] Do not enable the encoding detector by default.
Comment 1 Raphael Kubo da Costa (:rakuco) 2011-05-30 13:53:06 PDT 
Created attachment 95368 [details]
Patch
Comment 2 Lucas De Marchi 2011-05-30 14:27:27 PDT 
Comment on attachment 95368 [details]
Patch

Out of curiosity, what tests fail with this turned on?

Aren't they missing the encoding setting if they rely on them?
Comment 3 Raphael Kubo da Costa (:rakuco) 2011-05-30 19:06:17 PDT 
In this specific case, that's dom/xhtml/level3/core/documentgetinputencoding01.xhtml, which checks exactly for this.
Comment 4 Brent Fulgham 2011-05-31 21:03:54 PDT 
Comment on attachment 95368 [details]
Patch

Looks good to me.  When landing, please update the ChangeLog to include the helpful information that this code is exercised by the "dom/xhtml/level3/core/documentgetinputencoding01.xhtml" test.
Comment 5 Raphael Kubo da Costa (:rakuco) 2011-06-03 06:06:35 PDT 
Created attachment 95904 [details]
Same patch, more detailed ChangeLog

Sorry for the delay; this is the new patch explicitly mentioning dom/xhtml/level3/core/documentgetinputencoding01.xhtml.
Comment 6 WebKit Review Bot 2011-06-03 06:08:27 PDT 
Attachment 95904 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1

Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Raphael Kubo da Costa (:rakuco) 2011-06-03 06:11:10 PDT 
Huh? Is there a way to re-run the style bot?
Comment 8 Lucas De Marchi 2011-06-03 07:30:36 PDT 
(In reply to comment #7)
> Huh? Is there a way to re-run the style bot?

I think that you need to upload it again.
Comment 9 Raphael Kubo da Costa (:rakuco) 2011-06-03 08:42:41 PDT 
Created attachment 95917 [details]
Same patch, more detailed ChangeLog, take #2
Comment 10 WebKit Review Bot 2011-06-03 08:44:40 PDT 
Attachment 95917 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1

Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Gyuyoung Kim 2011-06-09 17:09:03 PDT 
It seems there is no style errors. So, you need to update this patch again.
Comment 12 Lucas De Marchi 2011-06-09 19:43:56 PDT 
Committed r88515: <http://trac.webkit.org/changeset/88515>
Comment 13 Eric Seidel (no email) 2011-06-18 13:40:35 PDT 
Comment on attachment 95917 [details]
Same patch, more detailed ChangeLog, take #2

Cleared review? from attachment 95917 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Comment 14 Kenneth Rohde Christiansen 2012-10-09 05:12:36 PDT 
Comment on attachment 95917 [details]
Same patch, more detailed ChangeLog, take #2

View in context: https://bugs.webkit.org/attachment.cgi?id=95917&action=review

> a/Source/WebKit/efl/ChangeLog:9
> +        This should match the behaviour of other ports more closely, and makes
> +        at least dom/xhtml/level3/core/documentgetinputencoding01.xhtml pass.

So if all browsers enable (or should enable) it anyway, what is the point? Isn't this a bug in the decoding detector instead?