Bug 98707 – [chromium] Expose background color in WebLayer and WebSolidColorLayer

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Scott Violet]

So that we can query for current state.

[Scott Violet]

Created attachment 167659 [details]
Fix for 98707:

[Antoine Labour]

Comment on attachment 167659 [details]
Fix for 98707:

View in context: https://bugs.webkit.org/attachment.cgi?id=167659&action=review

> Source/Platform/chromium/public/WebSolidColorLayer.h:43
> +    virtual WebColor getBackgroundColor() const = 0;

Not needed since you can get it through layer()

[Dana Jansens]

Comment on attachment 167659 [details]
Fix for 98707:

View in context: https://bugs.webkit.org/attachment.cgi?id=167659&action=review

> Source/Platform/chromium/public/WebLayer.h:122
> +    virtual WebColor getBackgroundColor() const = 0;

naming nit: just "backgroundColor()"

[Scott Violet]

Created attachment 167763 [details]
Fix v2

getBackgroundColor -> backgroundColor and removes changes to WebSolidColorLayer.

[James Robinson]

Looks good, we'll just have to wait for the chromium side to land + roll into Source/WebKit/chromium/DEPS

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Comment on attachment 167763 [details]
Fix v2

Rejecting attachment 167763 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Core/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 https://bugs.webkit.org/show_bug.cgi?id=95664

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/14245741

[WebKit Review Bot]

Comment on attachment 167763 [details]
Fix v2

Clearing flags on attachment: 167763

Committed r131013: <http://trac.webkit.org/changeset/131013>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.