Bug 98707 - [chromium] Expose background color in WebLayer and WebSolidColorLayer
Summary: [chromium] Expose background color in WebLayer and WebSolidColorLayer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Iain Merrick
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-08 17:53 PDT by Scott Violet
Modified: 2012-10-10 21:49 PDT (History)
7 users (show)

See Also:


Attachments
Fix for 98707: (1.71 KB, patch)
2012-10-08 17:56 PDT, Scott Violet
no flags Details | Formatted Diff | Diff
Fix v2 (1.11 KB, patch)
2012-10-09 08:45 PDT, Scott Violet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Violet 2012-10-08 17:53:49 PDT
So that we can query for current state.
Comment 1 Scott Violet 2012-10-08 17:56:21 PDT
Created attachment 167659 [details]
Fix for 98707:
Comment 2 Antoine Labour 2012-10-08 18:02:37 PDT
Comment on attachment 167659 [details]
Fix for 98707:

View in context: https://bugs.webkit.org/attachment.cgi?id=167659&action=review

> Source/Platform/chromium/public/WebSolidColorLayer.h:43
> +    virtual WebColor getBackgroundColor() const = 0;

Not needed since you can get it through layer()
Comment 3 Dana Jansens 2012-10-08 20:15:59 PDT
Comment on attachment 167659 [details]
Fix for 98707:

View in context: https://bugs.webkit.org/attachment.cgi?id=167659&action=review

> Source/Platform/chromium/public/WebLayer.h:122
> +    virtual WebColor getBackgroundColor() const = 0;

naming nit: just "backgroundColor()"
Comment 4 Scott Violet 2012-10-09 08:45:39 PDT
Created attachment 167763 [details]
Fix v2

getBackgroundColor -> backgroundColor and removes changes to WebSolidColorLayer.
Comment 5 James Robinson 2012-10-09 11:20:01 PDT
Looks good, we'll just have to wait for the chromium side to land + roll into Source/WebKit/chromium/DEPS
Comment 6 WebKit Review Bot 2012-10-10 17:56:33 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 7 WebKit Review Bot 2012-10-10 18:44:53 PDT
Comment on attachment 167763 [details]
Fix v2

Rejecting attachment 167763 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Core/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 https://bugs.webkit.org/show_bug.cgi?id=95664

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/14245741
Comment 8 WebKit Review Bot 2012-10-10 21:49:47 PDT
Comment on attachment 167763 [details]
Fix v2

Clearing flags on attachment: 167763

Committed r131013: <http://trac.webkit.org/changeset/131013>
Comment 9 WebKit Review Bot 2012-10-10 21:49:50 PDT
All reviewed patches have been landed.  Closing bug.