Bug 95664 - [Shadow DOM] should be able to be available without <style scoped>
Summary: [Shadow DOM] should be able to be available without <style scoped>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
: 92053 (view as bug list)
Depends on: 96315 98244 98842
Blocks: 94082
  Show dependency tree / graph
 
Reported: 2012-09-02 21:38 PDT by Hajime Morrita
Modified: 2012-10-10 18:00 PDT (History)
6 users (show)

See Also:

Attachments
Patch (11.87 KB, patch)
2012-09-03 03:23 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Updated to ToT (11.79 KB, patch)
2012-09-05 23:19 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch (11.86 KB, patch)
2012-09-14 08:56 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch (19.33 KB, patch)
2012-10-09 21:37 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-09-02 21:38:42 PDT 
Since styling for Shadow DOM relies on scoped stylesheet internal implementation,
Shadow DOM want it even when <style scoped> is disabled.
Comment 1 Hajime Morrita 2012-09-03 03:23:25 PDT 
Created attachment 161892 [details]
Patch
Comment 2 Hajime Morrita 2012-09-05 23:19:43 PDT 
Created attachment 162425 [details]
Updated to ToT
Comment 3 Hajime Morrita 2012-09-10 16:14:01 PDT 
Comment on attachment 162425 [details]
Updated to ToT

Dimitri, do you think we need this?
Comment 4 Dimitri Glazkov (Google) 2012-09-10 16:16:14 PDT 
Comment on attachment 162425 [details]
Updated to ToT

No, not at the moment.
Comment 5 Hajime Morrita 2012-09-14 08:56:43 PDT 
Created attachment 164165 [details]
Patch
Comment 6 Ryosuke Niwa 2012-09-17 13:52:39 PDT 
Comment on attachment 164165 [details]
Patch

What should be available without scoped style element?
Comment 7 Hajime Morrita 2012-09-17 19:30:47 PDT 
(In reply to comment #6)
> (From update of attachment 164165 [details])
> What should be available without scoped style element?
Style scoping using ShadowRoot.
Comment 8 Hajime Morrita 2012-09-20 18:44:08 PDT 
*** Bug 92053 has been marked as a duplicate of this bug. ***
Comment 9 Hajime Morrita 2012-10-09 21:37:02 PDT 
Created attachment 167914 [details]
Patch
Comment 10 Hajime Morrita 2012-10-09 21:41:55 PDT 
This one is ready!

I hope I could eliminated more guards. But scope related code in css/ isn't cleanly separated
from StyleResolver yet, that makes me hesitate to eliminate these flags.

I'm thinking about how we could refactor it, but I'd like to land this before further refactoring
so that we can make sure the styling feature to be available for Shadow DOM regardless of
<style scoped> availability.
Comment 11 WebKit Review Bot 2012-10-10 18:00:38 PDT 
Comment on attachment 167914 [details]
Patch

Clearing flags on attachment: 167914

Committed r130987: <http://trac.webkit.org/changeset/130987>
Comment 12 WebKit Review Bot 2012-10-10 18:00:43 PDT 
All reviewed patches have been landed.  Closing bug.