Bug 98657 - [EFL][WK2] Simplify frame flattening support in MiniBrowser
Summary: [EFL][WK2] Simplify frame flattening support in MiniBrowser
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Depends on: 98649
  Show dependency treegraph
Reported: 2012-10-08 09:43 PDT by Chris Dumez
Modified: 2012-10-08 11:23 PDT (History)
7 users (show)

See Also:

Patch (4.19 KB, patch)
2012-10-08 09:49 PDT, Chris Dumez
kenneth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (4.24 KB, patch)
2012-10-08 10:25 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-10-08 09:43:16 PDT
The frame_flattening setting is currently being passed around to the window_create() function which is not the most convenient.
We should find a nicer way to support frame flattening in MiniBrowser.
Comment 1 Chris Dumez 2012-10-08 09:49:16 PDT
Created attachment 167550 [details]
Comment 2 WebKit Review Bot 2012-10-08 10:20:26 PDT
Comment on attachment 167550 [details]

Rejecting attachment 167550 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Hunk #3 FAILED at 168.
Hunk #4 succeeded at 226 (offset 2 lines).
Hunk #5 succeeded at 304 (offset 2 lines).
Hunk #6 succeeded at 335 (offset 2 lines).
Hunk #7 succeeded at 372 (offset 2 lines).
Hunk #8 succeeded at 396 (offset 2 lines).
1 out of 8 hunks FAILED -- saving rejects to file Tools/MiniBrowser/efl/main.c.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14223295
Comment 3 Chris Dumez 2012-10-08 10:25:09 PDT
Created attachment 167555 [details]
Patch for landing

Rebased on master. Could someone please cq+?
Comment 4 WebKit Review Bot 2012-10-08 11:23:00 PDT
Comment on attachment 167555 [details]
Patch for landing

Clearing flags on attachment: 167555

Committed r130658: <http://trac.webkit.org/changeset/130658>
Comment 5 WebKit Review Bot 2012-10-08 11:23:04 PDT
All reviewed patches have been landed.  Closing bug.