Bug 98649 – [EFL][WK2] Add support for window.create in Minibrowser

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Chris Dumez]

When calling window.create() from JavaScript, MiniBrowser does not currently create a new window as directed.

[Chris Dumez]

Created attachment 167536 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 167536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167536&action=review

> Tools/MiniBrowser/efl/main.c:226
> +    Browser_Window *window = window_create(NULL, EINA_FALSE);

shouldnt it inherit the flattening? anyway I guess that should be fixed differently because it is quite ugly to pass around like this

[WebKit Review Bot]

Comment on attachment 167536 [details]
Patch

Rejecting attachment 167536 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ce', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Parsed 2 diffs from patch file(s).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/MiniBrowser/efl/main.c
Hunk #3 FAILED at 357.
1 out of 3 hunks FAILED -- saving rejects to file Tools/MiniBrowser/efl/main.c.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14224007

[Chris Dumez]

Created attachment 167542 [details]
Patch for landing

Rebased on master. Could someone please cq+ ?

[WebKit Review Bot]

Comment on attachment 167542 [details]
Patch for landing

Clearing flags on attachment: 167542

Committed r130646: <http://trac.webkit.org/changeset/130646>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.