Bug 98560 - Rendering/Layout issue of CJK vertical text with some font
Summary: Rendering/Layout issue of CJK vertical text with some font
Status: RESOLVED DUPLICATE of bug 98545
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-05 15:02 PDT by Xianzhu Wang
Modified: 2012-10-08 15:24 PDT (History)
4 users (show)

See Also:


Attachments
test case (html) (461 bytes, text/html)
2012-10-05 15:02 PDT, Xianzhu Wang
no flags Details
test case (font file) (385.75 KB, application/octet-stream)
2012-10-05 15:03 PDT, Xianzhu Wang
no flags Details
Current DRT pixel result (7.03 KB, image/png)
2012-10-05 15:06 PDT, Xianzhu Wang
no flags Details
Patch (1.64 KB, patch)
2012-10-08 11:51 PDT, Enrica Casucci
tony: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-10-05 15:02:45 PDT
Created attachment 167392 [details]
test case (html)

Save both of the test case files and open the HTML in Mac browser.

Actual result:
1) The vertical line is wrapped;
2) The '}' character and the previous CJK character overlaps

Expected
1) No wrapping
2) No overlapping
Comment 1 Xianzhu Wang 2012-10-05 15:03:17 PDT
Created attachment 167393 [details]
test case (font file)
Comment 2 Xianzhu Wang 2012-10-05 15:06:58 PDT
Created attachment 167395 [details]
Current DRT pixel result
Comment 3 Enrica Casucci 2012-10-07 19:28:00 PDT
I think this is a regression from r130443.
I'll post a fix shortly for it.
Comment 4 Enrica Casucci 2012-10-07 19:37:19 PDT
I confirmed that my fix solved this issue.
I'll post a patch.
Comment 5 Enrica Casucci 2012-10-08 11:51:16 PDT
Created attachment 167575 [details]
Patch
Comment 6 Tony Chang 2012-10-08 11:56:09 PDT
Comment on attachment 167575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167575&action=review

Can you make a layout test from the attached files on this bug?

> Source/WebCore/ChangeLog:11
> +        Fixes a regression introduced with r130443.
> +
> +        * platform/graphics/FontFastPath.cpp:
> +        (WebCore::Font::glyphDataAndPageForCharacter):

Please describe the fix here.
Comment 7 Enrica Casucci 2012-10-08 11:59:42 PDT
(In reply to comment #6)
> (From update of attachment 167575 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167575&action=review
> 
> Can you make a layout test from the attached files on this bug?
> 
> > Source/WebCore/ChangeLog:11
> > +        Fixes a regression introduced with r130443.
> > +
> > +        * platform/graphics/FontFastPath.cpp:
> > +        (WebCore::Font::glyphDataAndPageForCharacter):
> 
> Please describe the fix here.

I thought it was straightforward. I'll add a comment and the test.
Comment 8 Enrica Casucci 2012-10-08 15:13:46 PDT
Resolving as duplicate. I'll post the updated patch in the original bug and update the TestExpectations also for Mac.

*** This bug has been marked as a duplicate of bug 98545 ***