Bug 98545 - [chromium] fast/text/international/text-spliced-font.html and fast/writing-mode/Kusa-Makura-background-canvas.html failing on the Mac after r130443
Summary: [chromium] fast/text/international/text-spliced-font.html and fast/writing-mo...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
: 98560 (view as bug list)
Depends on:
Blocks: 98317
  Show dependency treegraph
Reported: 2012-10-05 12:06 PDT by Dirk Pranke
Modified: 2012-10-09 13:28 PDT (History)
5 users (show)

See Also:

Patch (589.83 KB, patch)
2012-10-09 10:51 PDT, Enrica Casucci
tony: review-
Details | Formatted Diff | Diff
Patch (1.73 KB, patch)
2012-10-09 12:24 PDT, Enrica Casucci
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-10-05 12:06:49 PDT
and it looks like we're a bit unclear as to whether the new results are correct or not, so I've marked the tests as failures for now and added a new baseline for fast/text/vertical-rl-rtl-linebreak.html but I don't know if that's right or not, either.
Comment 1 Dirk Pranke 2012-10-05 12:07:15 PDT
At least on Lion and SnowLeopard; this may not be failing on ML.
Comment 3 Enrica Casucci 2012-10-07 19:29:35 PDT
I found a problem in r130443 that could explain this. I'll post a fix shortly.
Comment 4 Enrica Casucci 2012-10-08 13:55:36 PDT
Could you please verify that the patch I posted for 98560 fixes this problem?
Comment 5 Dirk Pranke 2012-10-08 14:52:04 PDT
Yes, it appears that that patch fixes these failures. Thanks!.
Comment 6 Enrica Casucci 2012-10-08 15:13:46 PDT
*** Bug 98560 has been marked as a duplicate of this bug. ***
Comment 7 Enrica Casucci 2012-10-09 10:51:26 PDT
Created attachment 167781 [details]

The patch is very large, but the code change is extremely small.
The large is due to the moving of last expected results to another platform folder.
Comment 8 Enrica Casucci 2012-10-09 11:09:39 PDT
Committed revision 130779.
Comment 9 Tony Chang 2012-10-09 11:55:09 PDT
Comment on attachment 167781 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=167781&action=review

> Source/WebCore/platform/graphics/FontFastPath.cpp:228
> +            if (isCJKIdeographOrSymbol(c) && data.fontData->platformData().orientation() != Horizontal && !data.fontData->isTextOrientationFallback())

Sorry, this is backwards.  It should be !isCJKIdeographOrSymbol(c)
Comment 10 Tony Chang 2012-10-09 11:55:28 PDT
Comment 11 Enrica Casucci 2012-10-09 12:09:20 PDT
(In reply to comment #10)
> Reopening.

Sorry, I must have deleted a character by mistake before I submitted.
I'll fix it.
Comment 12 Enrica Casucci 2012-10-09 12:24:18 PDT
Created attachment 167815 [details]
Comment 13 Enrica Casucci 2012-10-09 13:28:30 PDT
Committed revision 130803.