Bug 98187 - Remove cases of testRunner.disableImageLoading() from the layout tests.
Summary: Remove cases of testRunner.disableImageLoading() from the layout tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks: 98083
  Show dependency tree / graph
 
Reported: 2012-10-02 12:15 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2012-10-02 13:19 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.68 KB, patch)
2012-10-02 12:19 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2012-10-02 12:15:56 PDT 
Remove cases of testRunner.disableImageLoading() from the layout tests.
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-10-02 12:19:24 PDT 
Created attachment 166729 [details]
Patch
Comment 2 Simon Fraser (smfr) 2012-10-02 12:46:04 PDT 
Comment on attachment 166729 [details]
Patch

Does the WebKitDisplayImagesKey get reset by WTR/DRT between tests?
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-10-02 13:16:51 PDT 
(In reply to comment #2)
> (From update of attachment 166729 [details])
> Does the WebKitDisplayImagesKey get reset by WTR/DRT between tests?

The behavior seems to be port-dependent -- at least the Mac (and thus probably win), EFL, GTK+ and Chromium TestRunners reset that value between each test. WTR seems to do that as well by calling WKPreferencesResetTestRunnerOverrides().
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-10-02 13:19:37 PDT 
Comment on attachment 166729 [details]
Patch

Clearing flags on attachment: 166729

Committed r130201: <http://trac.webkit.org/changeset/130201>
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-10-02 13:19:48 PDT 
All reviewed patches have been landed.  Closing bug.