Bug 98083 - Remove testRunner.disableImageLoading()
Summary: Remove testRunner.disableImageLoading()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on: 98187 98200
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-01 15:40 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2012-12-09 11:19 PST (History)
6 users (show)

See Also:

Attachments
Patch (10.56 KB, patch)
2012-11-22 07:22 PST, Zan Dobersek 		gustavo: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2012-10-01 15:40:18 PDT 
testRunner.overridePreference("WebKitDisplayImagesKey", 0) achieves the same effect, and we tend to prefer adding these settings to overridePreferences (see the discussion in http://lists.webkit.org/pipermail/webkit-dev/2012-September/022323.html).

There is only one test that calls disableImageLoading(), but we need to check that there are no ports which implement disableImageLoading() but not overridePreference("WebKitDisplayImagesKey", ...).
Comment 1 Zan Dobersek 2012-11-22 07:22:06 PST 
Created attachment 175671 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-09 01:59:21 PST 
Comment on attachment 175671 [details]
Patch

Rejecting attachment 175671 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
mpRenderTree/mac/TestRunnerMac.mm
Hunk #1 succeeded at 631 (offset 5 lines).
patching file Tools/DumpRenderTree/qt/TestRunnerQt.cpp
Hunk #1 succeeded at 563 with fuzz 1.
patching file Tools/DumpRenderTree/qt/TestRunnerQt.h
patching file Tools/DumpRenderTree/win/TestRunnerWin.cpp
patching file Tools/DumpRenderTree/wx/TestRunnerWx.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gustavo No..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15236019
Comment 3 Zan Dobersek 2012-12-09 11:18:56 PST 
Thanks for the review, manually landed in r137080.
http://trac.webkit.org/changeset/137080