Bug 98089 – Missing sys/mman.h include on Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Jonathan Liu]

Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp needs sys/mman.h include on Mac (see https://bugs.webkit.org/show_bug.cgi?id=97995#c5).

[Jonathan Liu]

Created attachment 166567 [details]
Patch

[Alexey Proskuryakov]

I want to r+ this based on the comment you cited, but I don't understand why the build isn't broken because of this.

[Jonathan Liu]

An indirect include from one of the other headers perhaps.

[Simon Hausmann]

I don't understand why this is needed. The Mac (apple & QT) bots are green.

[Jonathan Liu]

(In reply to comment #4)
> I don't understand why this is needed. The Mac (apple & QT) bots are green.

See https://bugs.webkit.org/show_bug.cgi?id=97995#c5

[Darin Adler]

Comment on attachment 166567 [details]
Patch

Eventually we’ll have to figure out a policy for Mac includes. Generally speaking the Mac port works by including certain global includes as part of the prefix, and patches like this are only needed because some other ports are leaving things out of the global prefix. But since we have a "config.h" that is used on all platforms, these could instead be fixed by adding more to the "config.h" or something it includes on those ports. Instead of constantly taking small patches like this one.

But I’ll set that aside for now and say r=me

[WebKit Review Bot]

Comment on attachment 166567 [details]
Patch

Clearing flags on attachment: 166567

Committed r139926: <http://trac.webkit.org/changeset/139926>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.