Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp contains an include for sys/mman.h that isn't used. As sys/mman.h is not available on all operating systems, this also improves portability.
Created attachment 166415 [details] Patch
Comment on attachment 166415 [details] Patch ok
Comment on attachment 166415 [details] Patch Clearing flags on attachment: 166415 Committed r130014: <http://trac.webkit.org/changeset/130014>
All reviewed patches have been landed. Closing bug.
Comment on attachment 166415 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166415&action=review > Source/JavaScriptCore/ChangeLog:9 > + The sys/mman.h is not used and removing it improves portability as not > + all systems have sys/mman.h. Where did you get the information <sys/mman.h> is not used? On OS X the madvise function and MADV_FREE constant that are used in this file is from that header. The correct change would be to put this include inside #if OS(DARWIN). Unless there is some other reason that we don’t need the include on OS X that I am not aware of.