Bug 98045 - [Qt][WK2] REGRESSION(r130029): It broke an API test
Summary: [Qt][WK2] REGRESSION(r130029): It broke an API test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords:
Depends on:
Blocks: 70236 97773
  Show dependency tree / graph
 
Reported: 2012-10-01 10:00 PDT by Csaba Osztrogonác
Modified: 2013-02-26 03:57 PST (History)
8 users (show)

See Also:

Attachments
Patch (3.38 KB, patch)
2012-10-02 04:33 PDT, Jocelyn Turcotte 		no flags Details | Formatted Diff | Diff
Patch (3.57 KB, patch)
2012-10-03 03:47 PDT, Jocelyn Turcotte 		hausmann: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-10-01 10:00:27 PDT 
********* Start testing of tst_QQuickWebView *********
...
FAIL!  : tst_QQuickWebView::scrollRequest() 'webView()->contentY() == y' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp(452)]
...
Comment 1 Jocelyn Turcotte 2012-10-02 04:33:37 PDT 
Created attachment 166664 [details]
Patch

Thanks, here's a fix.
Comment 2 WebKit Review Bot 2012-10-02 07:37:10 PDT 
Comment on attachment 166664 [details]
Patch

Clearing flags on attachment: 166664

Committed r130168: <http://trac.webkit.org/changeset/130168>
Comment 3 WebKit Review Bot 2012-10-02 07:37:13 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2012-10-02 23:33:16 PDT 
(In reply to comment #2)
> (From update of attachment 166664 [details])
> Clearing flags on attachment: 166664
> 
> Committed r130168: <http://trac.webkit.org/changeset/130168>

Reopen, because the bug is still valid after this fix.

FAIL!  : tst_QQuickWebView::scrollRequest() 'webView()->contentY() == y' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp(453)]
Comment 5 Jocelyn Turcotte 2012-10-03 03:47:04 PDT 
Created attachment 166849 [details]
Patch

This one was a real bug I couldn't get on Linux but got on Mac.
Let's see if this is the same issue, this is an improvement in any case.
Comment 6 Jocelyn Turcotte 2012-10-04 03:43:46 PDT 
Committed r130382: <http://trac.webkit.org/changeset/130382>