Bug 98000 – [WebSocket] Add "Cache-Control: no-cache" to handshake request

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Kenichi Ishibashi]

For compatibility improvement. Please refer followings.

http://code.google.com/p/chromium/issues/detail?id=148908
http://www.ietf.org/mail-archive/web/hybi/current/msg09841.html

I wait and see how the discussion on hybi goes. I'll create a patch unless no one has any objections.

[Yuta Kitamura]

It is somewhat hard to keep track of the history of this issue, so I'd like to
summarize the motivation of this bug.

A user report in Chromium bug 148908 revealed that there is a (broken) proxy
server in the wild, which rewrites "Connection: Upgrade" in the response to "Connection: close" (which causes the opening handshake to fail).

It turned out that this can be avoided by adding "Pragma: no-cache" and
"Cache-Control: no-cache" in the request headers. Seems like the proxy is
trying to cache WebSocket's opening handshake, and the Connection header is
modified as a result.

Firefox has been sending no-cache headers and running without problems.

I would like to wait and watch the HyBi thread, but for now I feel we should
do the same as Firefox. I think there will be no bad side effect.

[Kenichi Ishibashi]

Created attachment 168365 [details]
Patch

[Yuta Kitamura]

Comment on attachment 168365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168365&action=review

> Source/WebCore/Modules/websockets/WebSocketHandshake.cpp:215
> +

You need to add these headers in clientHandshakeRequest() function, too. Web Inspecter will use
it to display request headers.

> LayoutTests/http/tests/websocket/tests/hybi/nocache-expected.txt:8
> +FAIL closeEvent.wasClean should be true. Threw exception ReferenceError: closeEvent is not defined

This needs to be fixed.

[Kenichi Ishibashi]

Created attachment 168367 [details]
Patch

[Kenichi Ishibashi]

Comment on attachment 168365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168365&action=review

>> Source/WebCore/Modules/websockets/WebSocketHandshake.cpp:215
>> +
> 
> You need to add these headers in clientHandshakeRequest() function, too. Web Inspecter will use
> it to display request headers.

Done.

>> LayoutTests/http/tests/websocket/tests/hybi/nocache-expected.txt:8
>> +FAIL closeEvent.wasClean should be true. Threw exception ReferenceError: closeEvent is not defined
> 
> This needs to be fixed.

Oops. Thanks. Fixed.

[Yuta Kitamura]

Comment on attachment 168367 [details]
Patch

OK. The HyBi thread has been silent, and there seems no objections.

[Kenichi Ishibashi]

Comment on attachment 168367 [details]
Patch

Thanks!

[WebKit Review Bot]

Comment on attachment 168367 [details]
Patch

Clearing flags on attachment: 168367

Committed r131155: <http://trac.webkit.org/changeset/131155>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.