Bug 148908 - Simplify JIT::emit_op_mod()
Summary: Simplify JIT::emit_op_mod()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-06 02:39 PDT by Sukolsak Sakshuwong
Modified: 2015-09-06 07:38 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.01 KB, patch)
2015-09-06 02:41 PDT, Sukolsak Sakshuwong 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sukolsak Sakshuwong 2015-09-06 02:39:27 PDT 
The IDIV instruction on x86 divides the value in the EDX:EAX registers by the source operand and stores the quotient in EAX and the remainder in EDX. Therefore, we store the values that we don't want to be overwritten by IDIV in registers that are not EAX or EDX. This patch makes the intention clearer and makes the code easier to read.
Comment 1 Sukolsak Sakshuwong 2015-09-06 02:41:23 PDT 
Created attachment 260708 [details]
Patch
Comment 2 Michael Saboff 2015-09-06 03:03:44 PDT 
Comment on attachment 260708 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2015-09-06 07:38:20 PDT 
Comment on attachment 260708 [details]
Patch

Clearing flags on attachment: 260708

Committed r189444: <http://trac.webkit.org/changeset/189444>
Comment 4 WebKit Commit Bot 2015-09-06 07:38:23 PDT 
All reviewed patches have been landed.  Closing bug.