Bug 97907 - [Qt] QRawWebView tests are broken after r129545
Summary: [Qt] QRawWebView tests are broken after r129545
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Balazs Kelemen
URL:
Keywords:
Depends on:
Blocks: 70236
  Show dependency tree / graph
 
Reported: 2012-09-28 06:36 PDT by Balazs Kelemen
Modified: 2012-09-28 06:55 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.29 KB, patch)
2012-09-28 06:46 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2012-09-28 06:36:07 PDT 
The issue here was that we were setting the page loader client before initialized the page. This is not correct, the API expects that the page is initialized, i.e. we have a living page at the web process side. Without that most of the API calls will be implicitly ignored. This has been revealed by http://trac.webkit.org/changeset/129545 because it changed the initializing of the loader client so that it requires sending a message.
Comment 1 Balazs Kelemen 2012-09-28 06:46:56 PDT 
Created attachment 166242 [details]
Patch
Comment 2 Balazs Kelemen 2012-09-28 06:55:34 PDT 
Comment on attachment 166242 [details]
Patch

Clearing flags on attachment: 166242

Committed r129890: <http://trac.webkit.org/changeset/129890>
Comment 3 Balazs Kelemen 2012-09-28 06:55:39 PDT 
All reviewed patches have been landed.  Closing bug.