Bug 97867 – Revert r122824 for a while

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Shinya Kawanaka]

Since it turned out there are a lot of difficulties about shadow dom spec for replaced elements, we would like to rollout r122824 until we re-design replaced elements spec.

[Dominic Cooney]

It is preferable to roll patches out as soon as possible; rolling them out later is riskier. What is the status of this?

[Shinya Kawanaka]

I tried this before but it was already complicated to roll it out, and I didn't have much time at time time. So I've postponed...
I'll try this again.

[Shinya Kawanaka]

Created attachment 182270 [details]
WIP

[Adam Barth]

Comment on attachment 182270 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=182270&action=review

> Source/WebCore/GNUmakefile.list.am:890
> +<<<<<<< HEAD
>  webcore_svg_built_sources += \
> +=======

This looks like a bad merge.

[Build Bot]

Comment on attachment 182270 [details]
WIP

Attachment 182270 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15872717

[Shinya Kawanaka]

Created attachment 182888 [details]
WIP

[Shinya Kawanaka]

Created attachment 182910 [details]
WIP

[Shinya Kawanaka]

Created attachment 183083 [details]
Patch

[Hajime Morrita]

Comment on attachment 183083 [details]
Patch

cq+ by yourself once bugs get green.

[WebKit Review Bot]

Comment on attachment 183083 [details]
Patch

Clearing flags on attachment: 183083

Committed r140097: <http://trac.webkit.org/changeset/140097>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

(In reply to comment #10)
> (From update of attachment 183083 [details])
> Clearing flags on attachment: 183083
> 
> Committed r140097: <http://trac.webkit.org/changeset/140097>

Something bad happened here, because it broke the Qt Windows build:
C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WTF\wtf/PassRefPtr.h(53) : error C2027: use of undefined type 'WebCore::Image'
        C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WebCore\html\HTMLPlugInElement.h(35) : see declaration of 'WebCore::Image'
        C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WTF\wtf/PassRefPtr.h(68) : see reference to function template instantiation 'void WTF::derefIfNotNull<T>(T *)' being compiled
        with
        [
            T=WebCore::Image
        ]
        C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WTF\wtf/PassRefPtr.h(68) : while compiling class template member function 'WTF::PassRefPtr<T>::~PassRefPtr(void)'
        with
        [
            T=WebCore::Image
        ]
        C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WebCore\html\HTMLPlugInElement.h(58) : see reference to class template instantiation 'WTF::PassRefPtr<T>' being compiled
        with
        [
            T=WebCore::Image
        ]
C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WTF\wtf/PassRefPtr.h(53) : error C2227: left of '->deref' must point to class/struct/union/generic type


Fix landed in https://trac.webkit.org/changeset/140138. 

But I don't understand this rollout ... 

https://trac.webkit.org/changeset/130810/trunk/Source/WebCore/html/HTMLPlugInElement.h broke the Windows build and https://trac.webkit.org/changeset/130814 fixed it. And https://trac.webkit.org/changeset/140097/trunk/Source/WebCore/html/HTMLPlugInElement.h reverted this buildfix and not the change of https://trac.webkit.org/changeset/122824/trunk/Source/WebCore/html/HTMLPlugInElement.h

[Csaba Osztrogonác]

Ooops, ImageLoaderClient.h doesn't exist anymore - one more fix landed in https://trac.webkit.org/changeset/140140/trunk/Source/WebCore/html/HTMLPlugInElement.h

[Hajime Morrita]

> Ooops, ImageLoaderClient.h doesn't exist anymore - one more fix landed in https://trac.webkit.org/changeset/140140/trunk/Source/WebCore/html/HTMLPlugInElement.h

Oops. I'm sorry for my absence and thanks for taking care of this.