WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
97867
Revert
r122824
for a while
https://bugs.webkit.org/show_bug.cgi?id=97867
Summary
Revert r122824 for a while
Shinya Kawanaka
Reported
2012-09-27 23:05:48 PDT
Since it turned out there are a lot of difficulties about shadow dom spec for replaced elements, we would like to rollout
r122824
until we re-design replaced elements spec.
Attachments
WIP
(282.25 KB, patch)
2013-01-10 23:14 PST
,
Shinya Kawanaka
no flags
Details
Formatted Diff
Diff
WIP
(80.63 KB, patch)
2013-01-15 17:58 PST
,
Shinya Kawanaka
no flags
Details
Formatted Diff
Diff
WIP
(81.87 KB, patch)
2013-01-15 19:59 PST
,
Shinya Kawanaka
no flags
Details
Formatted Diff
Diff
Patch
(82.17 KB, patch)
2013-01-16 18:15 PST
,
Shinya Kawanaka
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Dominic Cooney
Comment 1
2013-01-10 06:19:32 PST
It is preferable to roll patches out as soon as possible; rolling them out later is riskier. What is the status of this?
Shinya Kawanaka
Comment 2
2013-01-10 18:50:57 PST
I tried this before but it was already complicated to roll it out, and I didn't have much time at time time. So I've postponed... I'll try this again.
Shinya Kawanaka
Comment 3
2013-01-10 23:14:37 PST
Created
attachment 182270
[details]
WIP
Adam Barth
Comment 4
2013-01-14 19:11:47 PST
Comment on
attachment 182270
[details]
WIP View in context:
https://bugs.webkit.org/attachment.cgi?id=182270&action=review
> Source/WebCore/GNUmakefile.list.am:890 > +<<<<<<< HEAD > webcore_svg_built_sources += \ > +=======
This looks like a bad merge.
Build Bot
Comment 5
2013-01-14 20:07:19 PST
Comment on
attachment 182270
[details]
WIP
Attachment 182270
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/15872717
Shinya Kawanaka
Comment 6
2013-01-15 17:58:08 PST
Created
attachment 182888
[details]
WIP
Shinya Kawanaka
Comment 7
2013-01-15 19:59:29 PST
Created
attachment 182910
[details]
WIP
Shinya Kawanaka
Comment 8
2013-01-16 18:15:50 PST
Created
attachment 183083
[details]
Patch
Hajime Morrita
Comment 9
2013-01-16 18:30:37 PST
Comment on
attachment 183083
[details]
Patch cq+ by yourself once bugs get green.
WebKit Review Bot
Comment 10
2013-01-17 19:58:33 PST
Comment on
attachment 183083
[details]
Patch Clearing flags on attachment: 183083 Committed
r140097
: <
http://trac.webkit.org/changeset/140097
>
WebKit Review Bot
Comment 11
2013-01-17 19:58:39 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 12
2013-01-18 06:43:50 PST
(In reply to
comment #10
)
> (From update of
attachment 183083
[details]
) > Clearing flags on attachment: 183083 > > Committed
r140097
: <
http://trac.webkit.org/changeset/140097
>
Something bad happened here, because it broke the Qt Windows build: C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WTF\wtf/PassRefPtr.h(53) : error C2027: use of undefined type 'WebCore::Image' C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WebCore\html\HTMLPlugInElement.h(35) : see declaration of 'WebCore::Image' C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WTF\wtf/PassRefPtr.h(68) : see reference to function template instantiation 'void WTF::derefIfNotNull<T>(T *)' being compiled with [ T=WebCore::Image ] C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WTF\wtf/PassRefPtr.h(68) : while compiling class template member function 'WTF::PassRefPtr<T>::~PassRefPtr(void)' with [ T=WebCore::Image ] C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WebCore\html\HTMLPlugInElement.h(58) : see reference to class template instantiation 'WTF::PassRefPtr<T>' being compiled with [ T=WebCore::Image ] C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WTF\wtf/PassRefPtr.h(53) : error C2227: left of '->deref' must point to class/struct/union/generic type Fix landed in
https://trac.webkit.org/changeset/140138
. But I don't understand this rollout ...
https://trac.webkit.org/changeset/130810/trunk/Source/WebCore/html/HTMLPlugInElement.h
broke the Windows build and
https://trac.webkit.org/changeset/130814
fixed it. And
https://trac.webkit.org/changeset/140097/trunk/Source/WebCore/html/HTMLPlugInElement.h
reverted this buildfix and not the change of
https://trac.webkit.org/changeset/122824/trunk/Source/WebCore/html/HTMLPlugInElement.h
Csaba Osztrogonác
Comment 13
2013-01-18 06:49:42 PST
Ooops, ImageLoaderClient.h doesn't exist anymore - one more fix landed in
https://trac.webkit.org/changeset/140140/trunk/Source/WebCore/html/HTMLPlugInElement.h
Hajime Morrita
Comment 14
2013-01-20 17:37:15 PST
> Ooops, ImageLoaderClient.h doesn't exist anymore - one more fix landed in
https://trac.webkit.org/changeset/140140/trunk/Source/WebCore/html/HTMLPlugInElement.h
Oops. I'm sorry for my absence and thanks for taking care of this.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug