Bug 97852 - Remove unused features and reduce code duplications in PerfTestRunner
Summary: Remove unused features and reduce code duplications in PerfTestRunner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 97833
  Show dependency treegraph
 
Reported: 2012-09-27 20:29 PDT by Ryosuke Niwa
Modified: 2012-09-28 13:36 PDT (History)
4 users (show)

See Also:


Attachments
Patch (8.16 KB, patch)
2012-09-27 20:40 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Fixed a typo in ChangeLog (8.16 KB, patch)
2012-09-27 20:56 PDT, Ryosuke Niwa
haraken: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-09-27 20:29:20 PDT
Remove unused features and reduce code duplications in PerfTestRunner
Comment 1 Ryosuke Niwa 2012-09-27 20:40:28 PDT
Created attachment 166132 [details]
Patch
Comment 2 Kentaro Hara 2012-09-27 20:50:49 PDT
Comment on attachment 166132 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166132&action=review

> PerformanceTests/ChangeLog:9
> +        - Remove PerfTestRunner.log since it's never used.

Nit: PerfTestRunner.info?

> PerformanceTests/resources/runner.js:190
> +        return returnValue;
> +    }
>  
> -    var mallocMemoryStats = PerfTestRunner.computeStatistics([PerfTestRunner.getUsedMallocHeap()], "bytes");
> -    PerfTestRunner.printStatistics(mallocMemoryStats, "Malloc:");
> +    return end - start;

Is this correct? This function sometimes returns returnValue and sometimes returns end-start.
Comment 3 Ryosuke Niwa 2012-09-27 20:55:33 PDT
Comment on attachment 166132 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166132&action=review

>> PerformanceTests/ChangeLog:9
>> +        - Remove PerfTestRunner.log since it's never used.
> 
> Nit: PerfTestRunner.info?

Right.

>> PerformanceTests/resources/runner.js:190
>> +    return end - start;
> 
> Is this correct? This function sometimes returns returnValue and sometimes returns end-start.

Yes. When test.run returns a number, we use that value instead (see dom-perf.js for example).
Comment 4 Ryosuke Niwa 2012-09-27 20:56:15 PDT
Created attachment 166136 [details]
Fixed a typo in ChangeLog
Comment 5 Kentaro Hara 2012-09-27 21:08:20 PDT
Comment on attachment 166136 [details]
Fixed a typo in ChangeLog

Looks OK