Bug 97833 - Encapsulate private properties in PerfTestRunner better
Summary: Encapsulate private properties in PerfTestRunner better
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 97743 97852
Blocks: 77037
  Show dependency treegraph
 
Reported: 2012-09-27 17:23 PDT by Ryosuke Niwa
Modified: 2012-10-01 16:47 PDT (History)
8 users (show)

See Also:


Attachments
Cleanup (18.09 KB, patch)
2012-09-28 14:50 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Fixed a test (18.08 KB, patch)
2012-09-28 14:51 PDT, Ryosuke Niwa
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-09-27 17:23:50 PDT
Right now, "private" properties of PerfTestRunner are just regular properties prefixed with _. We can do better by enclosing everything in a closure.
Comment 1 Ryosuke Niwa 2012-09-28 14:50:03 PDT
Created attachment 166315 [details]
Cleanup
Comment 2 Ryosuke Niwa 2012-09-28 14:51:51 PDT
Created attachment 166316 [details]
Fixed a test
Comment 3 Ojan Vafai 2012-10-01 16:41:15 PDT
Comment on attachment 166316 [details]
Fixed a test

This is fine. A less fragile approach would be to wrap the whole file in an anonymous function and at the end of the function only expose the things you really want to expose, e.g.:

window.PerfTestRunner = PerfTestRunner;

That way, everything is private by default and people don't need to move code around to enable it to use a private helper function.
Comment 4 Ryosuke Niwa 2012-10-01 16:43:51 PDT
(In reply to comment #3)
> (From update of attachment 166316 [details])
> This is fine. A less fragile approach would be to wrap the whole file in an anonymous function and at the end of the function only expose the things you really want to expose, e.g.:

Yup. I'm doing that in a follow up. I'm just trying to make the diff unreadable.
Comment 5 Ryosuke Niwa 2012-10-01 16:44:02 PDT
*readable.
Comment 6 Ryosuke Niwa 2012-10-01 16:47:55 PDT
Committed r130099: <http://trac.webkit.org/changeset/130099>