Bug 97680 - Web Inspector: Move UISourceCode creation out from ResourceScriptMapping.
Summary: Web Inspector: Move UISourceCode creation out from ResourceScriptMapping.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on: 97231
Blocks: 97032
  Show dependency tree / graph
 
Reported: 2012-09-26 07:07 PDT by Vsevolod Vlasov
Modified: 2012-10-02 05:12 PDT (History)
12 users (show)

See Also:

Attachments
Patch (62.91 KB, patch)
2012-09-26 07:21 PDT, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch (49.47 KB, patch)
2012-09-26 07:52 PDT, Vsevolod Vlasov 		pfeldman: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-09-26 07:07:24 PDT 
UISourceCodes for scripts having sourceURL are now created by NetworkUISourceCodeProvider.
UISourceCodes for anonymous, dynamic and concatenated scripts are now created on demand only.
All UISourceCodes created by ResourceScriptMapping are now "temporary".
Temporary UISourceCodes are not stored in workspace and removed when a normal UISourceCode with the same url is available.
UISourceCodeReplaced event was replaced with TemporaryUISourceCodeAdded/Removed events.
Comment 1 Vsevolod Vlasov 2012-09-26 07:21:23 PDT 
Created attachment 165797 [details]
Patch
Comment 2 Pavel Feldman 2012-09-26 07:49:32 PDT 
Comment on attachment 165797 [details]
Patch

Too much ChangeLog!
Comment 3 Vsevolod Vlasov 2012-09-26 07:52:39 PDT 
Created attachment 165801 [details]
Patch
Comment 4 WebKit Review Bot 2012-09-26 08:51:12 PDT 
Comment on attachment 165801 [details]
Patch

Attachment 165801 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14019569

New failing tests:
inspector/debugger/source-url-comment.html
Comment 5 Build Bot 2012-09-27 02:17:28 PDT 
Comment on attachment 165801 [details]
Patch

Attachment 165801 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14009055

New failing tests:
inspector/debugger/source-url-comment.html
Comment 6 Vsevolod Vlasov 2012-10-02 05:12:53 PDT 
Committed r130155: <http://trac.webkit.org/changeset/130155>