97231 – Web Inspector: Provide a way to distinguish scripts having sourceURL from standalone scripts.

Bug 97231 - Web Inspector: Provide a way to distinguish scripts having sourceURL from standalone scripts.

Summary: Web Inspector: Provide a way to distinguish scripts having sourceURL from sta...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Web Inspector (Deprecated) (show other bugs)
Version:	528+ (Nightly build)
Hardware:	All All

Importance:	P2 Normal
Assignee:	Vsevolod Vlasov

URL:
Keywords:

Depends on:
Blocks:	97680
	Show dependency tree / graph

Reported:	2012-09-20 10:20 PDT by Vsevolod Vlasov
Modified:	2012-10-02 12:16 PDT (History)
CC List:	14 users (show)

See Also:

Attachments
Patch (13.15 KB, patch) 2012-09-20 10:25 PDT, Vsevolod Vlasov	no flags	Details \| Formatted Diff \| Diff
Patch (13.11 KB, patch) 2012-09-20 10:28 PDT, Vsevolod Vlasov	pfeldman: review+ peter+ews: commit-queue-	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Vsevolod Vlasov 2012-09-20 10:20:06 PDT

Currently sourceURL field could be set for 
 - standalone scripts (<script src=foo.js></script>)
 - evals
 - scripts in dynamically created script element

To distinguish between first two we should provide hasSourceURL flag for each script.

Comment 1 Vsevolod Vlasov 2012-09-20 10:24:35 PDT

This patch depends on https://codereview.chromium.org/10966011/ landed in v8.

Comment 2 Vsevolod Vlasov 2012-09-20 10:25:20 PDT

Created attachment 164939 [details]
Patch

Comment 3 Vsevolod Vlasov 2012-09-20 10:28:58 PDT

Created attachment 164940 [details]
Patch

Comment 4 Peter Beverloo (cr-android ews) 2012-09-20 10:47:17 PDT

Comment on attachment 164940 [details]
Patch

Attachment 164940 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13955258

Comment 5 WebKit Review Bot 2012-09-20 12:55:49 PDT

Comment on attachment 164940 [details]
Patch

Attachment 164940 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13935277

Comment 6 Vsevolod Vlasov 2012-10-02 01:27:54 PDT

Committed r130138: <http://trac.webkit.org/changeset/130138>

Comment 7 Ojan Vafai 2012-10-02 11:50:20 PDT

inspector/debugger/source-url-comment.html times out on all the chromium bots.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&showExpectations=true&tests=inspector%2Fdebugger%2Fsource-url-comment.html

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=inspector%2Fdebugger%2Fsource-url-comment.html

Comment 8 Ojan Vafai 2012-10-02 12:16:28 PDT

Added to TestExpectations for now: http://trac.webkit.org/changeset/130193