Bug 97658 - [Cairo] Bump Cairo to fix more canvas/philip tests
Summary: [Cairo] Bump Cairo to fix more canvas/philip tests
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
: 54471 (view as bug list)
Depends on:
Blocks: 54458
  Show dependency treegraph
Reported: 2012-09-26 04:44 PDT by Dominik Röttsches (drott)
Modified: 2012-10-09 19:18 PDT (History)
7 users (show)

See Also:

Patch (deleted)
2012-10-09 09:33 PDT, Sudarsana Nagineni (babu)
no flags Details | Formatted Diff | Diff
Patch (deleted)
2012-10-09 17:43 PDT, Sudarsana Nagineni (babu)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Röttsches (drott) 2012-09-26 04:44:01 PDT
We've continued the analysis from 
and worked with Chris Wilson to address some of these issue. 

We've experimentally bumped cairo to 1.12 which has introduced new regressions:
fast/canvas/canvas-fillRect-gradient-shadow.html = TEXT
svg/batik/text/smallFonts.svg = TEXT
svg/batik/text/textGlyphOrientationHorizontal.svg = TEXT
svg/batik/text/textOnPath2.svg = TEXT
svg/batik/text/textOnPath3.svg = TEXT
svg/batik/text/textOnPathSpaces.svg = TEXT
svg/batik/text/verticalTextOnPath.svg = TEXT
svg/hixie/perf/001.xml = TEXT
svg/hixie/perf/002.xml = TEXT
svg/stroke/zero-length-path-linecap-rendering.svg = TEXT
svg/stroke/zero-length-subpaths-linecap-rendering.svg = TEXT
svg/transforms/transformed-text-fill-pattern.html = IMAGE

For which we filed 
https://bugs.freedesktop.org/show_bug.cgi?id=54446 "WebKit regression observed in Cairo commit 83bfd85"  (now resolved)
https://bugs.freedesktop.org/show_bug.cgi?id=54507 "WebKit regression found in Cairo commit 51594d9" (under investigation)

Once the second bug can be resolved (on either cairo side or WebKit side), we should be able to bump Cairo to at least f34b87f6d76cbea93acd4a8c73c8c6a6b412a302 or a release version after this commit.

This would resolve failures for (no webkit bugs):


WebKit Bug 54471:
Comment 1 Dominik Röttsches (drott) 2012-09-26 04:44:53 PDT
*** Bug 54471 has been marked as a duplicate of this bug. ***
Comment 2 Sudarsana Nagineni (babu) 2012-09-27 01:47:07 PDT
The stroke and hixie/perf tests are addressed in Cairo bug https://bugs.freedesktop.org/show_bug.cgi?id=54549 (commit b0c466e)
Comment 3 Sudarsana Nagineni (babu) 2012-10-09 09:33:50 PDT
Created attachment 167773 [details]

Bumped the cairo to version 1.12.4 in the jhbuild files for EFL and GTK. Also, unskipped canvas/philip tests which are passing now and updated platform-specific baselines for svg tests.
Comment 4 Martin Robinson 2012-10-09 09:37:10 PDT
I'm not sure if I understand the new shadow failure. Shadows are not rendered with Cairo, rather the shadow code works with the pixels of the image directly.
Comment 5 Sudarsana Nagineni (babu) 2012-10-09 17:43:37 PDT
Created attachment 167882 [details]

Updated the test case of new shadow failure in the bug #98760, after discussing with Martin a bit more.
Comment 6 WebKit Review Bot 2012-10-09 19:18:21 PDT
Comment on attachment 167882 [details]

Clearing flags on attachment: 167882

Committed r130840: <http://trac.webkit.org/changeset/130840>
Comment 7 WebKit Review Bot 2012-10-09 19:18:26 PDT
All reviewed patches have been landed.  Closing bug.