Bug 98760 - fast/canvas/canvas-fillRect-gradient-shadow.html failing
Summary: fast/canvas/canvas-fillRect-gradient-shadow.html failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-09 08:11 PDT by Sudarsana Nagineni (babu)
Modified: 2012-10-09 19:08 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.40 KB, patch)
2012-10-09 16:12 PDT, Sudarsana Nagineni (babu) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sudarsana Nagineni (babu) 2012-10-09 08:11:46 PDT 
fast/canvas/canvas-fillRect-gradient-shadow.html is failing with the cairo v1.12. The diff is:

--- WebKit/WebKitBuild/Debug/layout-test-results/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt
+++ WebKit/WebKitBuild/Debug/layout-test-results/fast/canvas/canvas-fillRect-gradient-shadow-actual.txt
@@ -79,7 +79,7 @@
 PASS d[1] is 0
 PASS d[2] is 0
 PASS d[3] is smaller than 15
-PASS d[0] is 255
+FAIL d[0] should be 255. Was 0.
 PASS d[1] is 0
 PASS d[2] is 0
 PASS d[3] is smaller than 15

It looks like we need to adjust the blur radius higher up in ShadowBlur computation since the test case is using small shadow blur value. Or, we can also fix this by altering the blur value in the test case.
http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/ShadowBlur.cpp#L227
Comment 1 Sudarsana Nagineni (babu) 2012-10-09 16:12:03 PDT 
Created attachment 167871 [details]
Patch

Adjusted the test case to verify the pixel in the middle of the shadow, instead of the outer edge.
Comment 2 WebKit Review Bot 2012-10-09 19:07:59 PDT 
Comment on attachment 167871 [details]
Patch

Clearing flags on attachment: 167871

Committed r130837: <http://trac.webkit.org/changeset/130837>
Comment 3 WebKit Review Bot 2012-10-09 19:08:03 PDT 
All reviewed patches have been landed.  Closing bug.