Bug 97611 - run-perf-tests: cleanup options and results generation code
Summary: run-perf-tests: cleanup options and results generation code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 97601
Blocks: 97613
  Show dependency tree / graph
 
Reported: 2012-09-25 15:18 PDT by Ryosuke Niwa
Modified: 2012-09-25 21:23 PDT (History)
6 users (show)

See Also:

Attachments
Patch (16.43 KB, patch)
2012-09-25 15:30 PDT, Ryosuke Niwa 		dpranke: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-09-25 15:18:06 PDT 
run-perf-tests: cleanup options and results generation code
Comment 1 Ryosuke Niwa 2012-09-25 15:30:30 PDT 
Created attachment 165687 [details]
Patch
Comment 2 Ryosuke Niwa 2012-09-25 15:31:36 PDT 
Once this patch is landed, I'll update master.cfg to use new options.
Comment 3 Ryosuke Niwa 2012-09-25 15:33:21 PDT 
Note that master.cfg change cannot be landed until all perf. bots cycle.
Comment 4 Dirk Pranke 2012-09-25 18:25:30 PDT 
Comment on attachment 165687 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165687&action=review

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:109
> +                help="Deprecated. Overrides --slave-config-json-path."),

Can you just use destination='slave_config_json_path' here?
Comment 5 Ryosuke Niwa 2012-09-25 18:32:06 PDT 
Committed r129580: <http://trac.webkit.org/changeset/129580>
Comment 6 Csaba Osztrogonác 2012-09-25 20:50:36 PDT 
FYI:It made the output of perf test malformed. See the Qt perf bot for details.
Comment 7 Ryosuke Niwa 2012-09-25 21:23:30 PDT 
Yeah, this should be fixed by https://trac.webkit.org/changeset/129589. Additionally, I'm recovering results for these runs so there should be no data loss. Sorry about the noise.