Bug 97601 - Perf-o-matic should store "values" and support array'ed input
Summary: Perf-o-matic should store "values" and support array'ed input
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 77037 97611
  Show dependency treegraph
 
Reported: 2012-09-25 13:56 PDT by Ryosuke Niwa
Modified: 2012-09-25 15:32 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.98 KB, patch)
2012-09-25 14:14 PDT, Ryosuke Niwa
dpranke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-09-25 13:56:45 PDT
Perf-o-matic should store "values" and support array'ed input
Comment 1 Ryosuke Niwa 2012-09-25 13:58:58 PDT
Because we've added results page, results JSON now contains an array instead of dictionary as the top level structure. We've also added "values" to some tests' results so that we may compute statistics later. Perf-o-matic needs to incorporate these changes in the JSON format.
Comment 2 Ryosuke Niwa 2012-09-25 14:14:08 PDT
Created attachment 165668 [details]
Patch
Comment 3 Dirk Pranke 2012-09-25 14:18:57 PDT
Comment on attachment 165668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165668&action=review

> Websites/webkit-perf.appspot.com/app.yaml:2
> +version: 20

nit: I've found it's useful to have the version of an application track the revision in svn for when the change lands. Just a suggestion if it's useful to you ...
Comment 4 Ryosuke Niwa 2012-09-25 14:21:41 PDT
Committed r129555: <http://trac.webkit.org/changeset/129555>
Comment 5 Ryosuke Niwa 2012-09-25 14:21:47 PDT
Comment on attachment 165668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165668&action=review

Thanks for the review.

>> Websites/webkit-perf.appspot.com/app.yaml:2
>> +version: 20
> 
> nit: I've found it's useful to have the version of an application track the revision in svn for when the change lands. Just a suggestion if it's useful to you ...

That sounds tricky. It means that I have to predict at which revision my change lands...
Comment 6 Dirk Pranke 2012-09-25 14:27:45 PDT
(In reply to comment #5)
> (From update of attachment 165668 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165668&action=review
> 
> Thanks for the review.
> 
> >> Websites/webkit-perf.appspot.com/app.yaml:2
> >> +version: 20
> > 
> > nit: I've found it's useful to have the version of an application track the revision in svn for when the change lands. Just a suggestion if it's useful to you ...
> 
> That sounds tricky. It means that I have to predict at which revision my change lands...

What I do is to leave the version in app.yaml alone and specify the version the change lands on upload, e.g., appcfg.py upload -V r123456 .