RESOLVED FIXED 97482
IndexedDB: Split up setVersion and deleteDatabase sequencing tests 
https://bugs.webkit.org/show_bug.cgi?id=97482
Summary IndexedDB: Split up setVersion and deleteDatabase sequencing tests
Joshua Bell
Reported 2012-09-24 14:25:50 PDT
IndexedDB: Split up setVersion and deleteDatabase sequencing tests
Attachments
Patch (87.43 KB, patch)
2012-09-24 14:29 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch for landing (87.45 KB, patch)
2012-09-27 14:32 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-09-24 14:29:13 PDT
Created attachment 165448 [details] Patch
Joshua Bell
Comment 2 2012-09-24 14:30:08 PDT
Nice simple tests now. We should get these running under chromium's browser_layouttests if they work.
Joshua Bell
Comment 3 2012-09-25 16:24:23 PDT
dgrogan@, alecflett@ - any comments before sending this off for review?
Joshua Bell
Comment 4 2012-09-27 12:56:40 PDT
tony@ - r? Just splitting up tests previous updated in webkit.org/b/97051 and webkit.org/b/97368
Tony Chang
Comment 5 2012-09-27 14:10:32 PDT
Comment on attachment 165448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165448&action=review > LayoutTests/storage/indexeddb/setversion-not-blocked.html:7 > +<script src="resources/setversion-not-blocked.js"></script> Nit: I would just inline js files that are only used in a single test. Less files in the tree and easier to find the code related to the test.
Joshua Bell
Comment 6 2012-09-27 14:30:15 PDT
(In reply to comment #5) > Nit: I would just inline js files that are only used in a single test. Less files in the tree and easier to find the code related to the test. We're planning make *-worker.html variants for nearly all of these tests at some point soon - and autogenerate the minimal HTML wrappers as well - hence this pattern.
Joshua Bell
Comment 7 2012-09-27 14:32:15 PDT
Created attachment 166064 [details] Patch for landing
WebKit Review Bot
Comment 8 2012-09-27 15:33:38 PDT
Comment on attachment 166064 [details] Patch for landing Clearing flags on attachment: 166064 Committed r129809: <http://trac.webkit.org/changeset/129809>
WebKit Review Bot
Comment 9 2012-09-27 15:33:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.