Bug 97368 - IndexedDB: Modernize some esoteric tests
Summary: IndexedDB: Modernize some esoteric tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on: 97051
Blocks: 97482
  Show dependency treegraph
 
Reported: 2012-09-21 15:03 PDT by Joshua Bell
Modified: 2012-09-27 12:56 PDT (History)
4 users (show)

See Also:


Attachments
Patch (50.57 KB, patch)
2012-09-21 15:05 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-09-21 15:03:44 PDT
IndexedDB: Modernize some esoteric tests
Comment 1 Joshua Bell 2012-09-21 15:05:23 PDT
Created attachment 165202 [details]
Patch
Comment 2 Joshua Bell 2012-09-21 15:09:30 PDT
A follow-on to http://webkit.org/b/97051 - this ditches all the debug() calls in favor of evalAndLog() and preamble().

No changes to how the tests operate. I was thinking of landing this, then splitting the tests up into separate files, but I could do both steps at once.
Comment 3 Alec Flett 2012-09-21 16:14:13 PDT
lgtm
Comment 4 Joshua Bell 2012-09-21 16:17:31 PDT
tony@ - r?

(low priority)
Comment 5 WebKit Review Bot 2012-09-24 09:19:36 PDT
Comment on attachment 165202 [details]
Patch

Clearing flags on attachment: 165202

Committed r129378: <http://trac.webkit.org/changeset/129378>
Comment 6 WebKit Review Bot 2012-09-24 09:19:39 PDT
All reviewed patches have been landed.  Closing bug.