Bug 97320 - Use emptyString instead of String("")
Summary: Use emptyString instead of String("")
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on: 86305
Blocks:
  Show dependency tree / graph
 
Reported: 2012-09-21 03:36 PDT by Patrick R. Gansterer
Modified: 2023-12-28 08:35 PST (History)
8 users (show)

See Also:

Attachments
Patch (14.26 KB, patch)
2012-09-21 03:46 PDT, Patrick R. Gansterer 		abarth: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-09-21 03:36:45 PDT 
Use emptyString instead of String("")
Comment 1 Patrick R. Gansterer 2012-09-21 03:46:35 PDT 
Created attachment 165110 [details]
Patch
Comment 2 Adam Barth 2012-09-21 09:09:40 PDT 
Comment on attachment 165110 [details]
Patch

My understanding is that emptyString is only safe to use on the main thread.  Many of these lines of code look like they can be reached on worker threads.
Comment 3 Benjamin Poulain 2012-09-21 14:14:51 PDT 
(Also see https://bugs.webkit.org/show_bug.cgi?id=95793 )
Comment 4 Anne van Kesteren 2023-12-28 08:35:32 PST 
git grep cannot find these instances anymore.