Bug 86305 - Use emptyString instead of String("")
Summary: Use emptyString instead of String("")
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks: 97320
  Show dependency tree / graph
 
Reported: 2012-05-12 16:42 PDT by Rob Buis
Modified: 2012-09-21 03:36 PDT (History)
3 users (show)

See Also:

Attachments
Patch (8.54 KB, patch)
2012-05-12 16:48 PDT, Rob Buis 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2012-05-12 16:42:08 PDT 
Use emptyString() instead of String("") because it is better style and faster.
Comment 1 Rob Buis 2012-05-12 16:48:08 PDT 
Created attachment 141588 [details]
Patch
Comment 2 Darin Adler 2012-05-13 15:52:33 PDT 
Comment on attachment 141588 [details]
Patch

We should also use emptyString() instead of just "" with an implicit conversion to String. Should find a some good way to locate those.
Comment 3 Rob Buis 2012-05-14 16:23:50 PDT 
Landed in r116908.
Comment 4 Eric Seidel (no email) 2012-05-14 16:32:10 PDT 
Are there things I can do to make webkit-patch land work better for you?

Or perhaps you'd like to use webkit-patch mark-bug-fixed after landing yourself?

You're welcome of course to use neither, but I'm surprised to see people adding their own "landed" messages by hand these days.
Comment 5 Rob Buis 2012-05-14 16:38:57 PDT 
(In reply to comment #4)
> Are there things I can do to make webkit-patch land work better for you?

Not really. It worked fine whenever I tried it.

> Or perhaps you'd like to use webkit-patch mark-bug-fixed after landing yourself?
> 
> You're welcome of course to use neither, but I'm surprised to see people adding their own "landed" messages by hand these days.

I often like to keep the bug open a day or so in case anybody complains/there are regressions. I could try looking into webkit-patch mark-bug-fixed though. Workflow sometimes is hard to change, but I'll give that one a shot, thanks!
Cheers,

Rob.