Currently, it is assumed that Constructor attribute is used only in DOMWindow.idl. We should release this condition. Bug 92413 is supposed to depend on this bug.
Created attachment 164213 [details] fix patch
Comment on attachment 164213 [details] fix patch View in context: https://bugs.webkit.org/attachment.cgi?id=164213&action=review > Source/WebCore/ChangeLog:8 > + In CodeGeneratorJS.pm, we should not assume only DOMWindow uses Constructor What about CodeGeneratorV8.pm?
Comment on attachment 164213 [details] fix patch View in context: https://bugs.webkit.org/attachment.cgi?id=164213&action=review >> Source/WebCore/ChangeLog:8 >> + In CodeGeneratorJS.pm, we should not assume only DOMWindow uses Constructor > > What about CodeGeneratorV8.pm? In V8, we use info.Holder(), which probably works in either case.
Comment on attachment 164213 [details] fix patch View in context: https://bugs.webkit.org/attachment.cgi?id=164213&action=review >>> Source/WebCore/ChangeLog:8 >>> + In CodeGeneratorJS.pm, we should not assume only DOMWindow uses Constructor >> >> What about CodeGeneratorV8.pm? > > In V8, we use info.Holder(), which probably works in either case. CodeGeneratorV8.pm uses info.Holder(), which is fine, but it looks like that CodeGeneratorV8.pm returns v8Undefined() for non-DOMWindow cases. We might want to fix the code: http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm&exact_package=chromium&q=codegeneratorv8.pm&type=cs&l=822
> > In V8, we use info.Holder(), which probably works in either case. > > CodeGeneratorV8.pm uses info.Holder(), which is fine, but it looks like that CodeGeneratorV8.pm returns v8Undefined() for non-DOMWindow cases. We might want to fix the code: > > http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm&exact_package=chromium&q=codegeneratorv8.pm&type=cs&l=822 The latest trunk looks like this: http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm#L810 It's quite different from your link.
Comment on attachment 164213 [details] fix patch > The latest trunk looks like this: > http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm#L810 Ah, the latest trunk looks good. Sorry for the noise!
Comment on attachment 164213 [details] fix patch Clearing flags on attachment: 164213 Committed r128655: <http://trac.webkit.org/changeset/128655>
All reviewed patches have been landed. Closing bug.