Bug 92413 - Support constructor-type static readonly attribute for CodeGenerator
Summary: Support constructor-type static readonly attribute for CodeGenerator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chang Shu
URL:
Keywords:
Depends on: 88920 91924 91925 96821
Blocks:
  Show dependency tree / graph
 
Reported: 2012-07-26 12:39 PDT by Chang Shu
Modified: 2012-09-14 13:07 PDT (History)
7 users (show)

See Also:

Attachments
fix patch (10.18 KB, patch)
2012-07-26 12:49 PDT, Chang Shu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2012-07-26 12:39:23 PDT 
When the static readonly attribute feature was added to CodeGenerator in commit 122912, it did not support "constructor" type attributes. The static constructor type attribute is useful when we define a js object type within an object type.
Comment 1 Chang Shu 2012-07-26 12:49:03 PDT 
Created attachment 154723 [details]
fix patch
Comment 2 Chang Shu 2012-07-26 13:56:44 PDT 
Thanks for the review, Adam.
Comment 3 WebKit Review Bot 2012-07-26 15:16:19 PDT 
Comment on attachment 154723 [details]
fix patch

Clearing flags on attachment: 154723

Committed r123800: <http://trac.webkit.org/changeset/123800>
Comment 4 WebKit Review Bot 2012-07-26 15:16:24 PDT 
All reviewed patches have been landed.  Closing bug.