Bug 96807 - IndexedDB: Calling close() during upgradeneeded handler should fire error at open request
Summary: IndexedDB: Calling close() during upgradeneeded handler should fire error at ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-14 10:53 PDT by Joshua Bell
Modified: 2012-09-14 17:08 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.44 KB, patch)
2012-09-14 10:58 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Patch for landing (8.44 KB, patch)
2012-09-14 15:34 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-09-14 10:53:50 PDT 
IndexedDB: Calling close() during upgradeneeded handler should fire error at open request
Comment 1 Joshua Bell 2012-09-14 10:58:53 PDT 
Created attachment 164192 [details]
Patch
Comment 2 Joshua Bell 2012-09-14 10:59:31 PDT 
This is one of the pieces factored out of http://webkit.org/b/90411

dgrogan@ - can you take a look?
Comment 3 David Grogan 2012-09-14 14:04:13 PDT 
Comment on attachment 164192 [details]
Patch

LGTM
Comment 4 Joshua Bell 2012-09-14 14:49:28 PDT 
tony@ - they just keep coming! r?
Comment 5 Tony Chang 2012-09-14 14:55:52 PDT 
Comment on attachment 164192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164192&action=review

> Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.cpp:109
> +        // If connection closed between onUpgradeNeeded and onSuccess, an error

Nit: If /the/ connection
Comment 6 Joshua Bell 2012-09-14 15:34:49 PDT 
Created attachment 164239 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-09-14 17:08:20 PDT 
Comment on attachment 164239 [details]
Patch for landing

Clearing flags on attachment: 164239

Committed r128674: <http://trac.webkit.org/changeset/128674>
Comment 8 WebKit Review Bot 2012-09-14 17:08:23 PDT 
All reviewed patches have been landed.  Closing bug.