Bug 96700 - [V8] Binding: Generate batched attribute/const/callback struct names can collide
Summary: [V8] Binding: Generate batched attribute/const/callback struct names can collide
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks: 90411
  Show dependency tree / graph
 
Reported: 2012-09-13 15:03 PDT by Joshua Bell
Modified: 2012-09-13 16:01 PDT (History)
6 users (show)

See Also:

Attachments
Patch (29.42 KB, patch)
2012-09-13 15:05 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Patch (26.23 KB, patch)
2012-09-13 15:16 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Patch for landing (26.28 KB, patch)
2012-09-13 15:21 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-09-13 15:03:04 PDT 
[V8] Binding: Generate batched attribute/const/callback structs into namespace
Comment 1 Joshua Bell 2012-09-13 15:05:34 PDT 
Created attachment 163974 [details]
Patch
Comment 2 Joshua Bell 2012-09-13 15:06:03 PDT 
I'm thinking of revising this to avoid the namespace, and just name the tables V8<ClassName>Callbacks (etc) instead.
Comment 3 Joshua Bell 2012-09-13 15:16:15 PDT 
Created attachment 163978 [details]
Patch
Comment 4 Joshua Bell 2012-09-13 15:16:47 PDT 
Revised patch - Just adds a "V8" prefix to the struct names. Much less churn.
Comment 5 Joshua Bell 2012-09-13 15:18:04 PDT 
abarth@ or haraken@ - r?
Comment 6 Kentaro Hara 2012-09-13 15:18:30 PDT 
Comment on attachment 163978 [details]
Patch

Looks better than introducing namespaces.
Comment 7 Joshua Bell 2012-09-13 15:20:03 PDT 
... and I'll fix the changelog entry about no new tests.
Comment 8 Joshua Bell 2012-09-13 15:21:31 PDT 
Created attachment 163980 [details]
Patch for landing
Comment 9 WebKit Review Bot 2012-09-13 16:01:13 PDT 
Comment on attachment 163980 [details]
Patch for landing

Clearing flags on attachment: 163980

Committed r128520: <http://trac.webkit.org/changeset/128520>
Comment 10 WebKit Review Bot 2012-09-13 16:01:17 PDT 
All reviewed patches have been landed.  Closing bug.