Bug 96537 - Regression(r128338): Broke Windows build
Summary: Regression(r128338): Broke Windows build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 96496
  Show dependency tree / graph
 
Reported: 2012-09-12 11:40 PDT by Chris Dumez
Modified: 2012-09-12 12:25 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.68 KB, patch)
2012-09-12 11:43 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (1.88 KB, patch)
2012-09-12 11:52 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-09-12 11:40:26 PDT 
r128338 broke Apple-Win build:
9>..\InjectedBundle\TestRunner.cpp(337) : error C2057: expected constant expression
9>..\InjectedBundle\TestRunner.cpp(337) : error C2466: cannot allocate an array of constant size 0
9>..\InjectedBundle\TestRunner.cpp(337) : error C2133: 'jsStringsArray' : unknown size
Comment 1 Chris Dumez 2012-09-12 11:43:22 PDT 
Created attachment 163663 [details]
Patch
Comment 2 Chris Dumez 2012-09-12 11:52:43 PDT 
Created attachment 163665 [details]
Patch

Use OwnArrayPtr.
Comment 3 WebKit Review Bot 2012-09-12 12:25:30 PDT 
Comment on attachment 163665 [details]
Patch

Clearing flags on attachment: 163665

Committed r128349: <http://trac.webkit.org/changeset/128349>
Comment 4 WebKit Review Bot 2012-09-12 12:25:34 PDT 
All reviewed patches have been landed.  Closing bug.