Bug 96496 – [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

TestRunner needs to implement originsWithApplicationCache().

This is needed by the following test case:
http/tests/appcache/origins-with-appcache.html

[Chris Dumez]

Created attachment 163589 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 163589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163589&action=review

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:333
> +static inline JSValueRef stringArrayToJS(JSContextRef context, WKArrayRef strings)

I guess this is fine as it only works with strings. Otherwise maybe we should just be a toJS overload.

[WebKit Review Bot]

Comment on attachment 163589 [details]
Patch

Rejecting attachment 163589 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
-queue/Source/WebKit/chromium/third_party/pyftpdlib/src --revision 977 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
43>At revision 977.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13827607

[Chris Dumez]

Created attachment 163651 [details]
Patch for landing

Could someone please cq+?

[WebKit Review Bot]

Comment on attachment 163651 [details]
Patch for landing

Clearing flags on attachment: 163651

Committed r128338: <http://trac.webkit.org/changeset/128338>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

Apparently broke Apple-Win build. Addressing the issue in Bug 96537.