Previously, in the llint C++ interpreter (in LowLevelInterpreter.h), I declared a handful of llint opcode aliases for opcode that look like this:
const OpcodeID llint_op_call = op_call;
const OpcodeID llint_op_call_eval = op_call_eval;
When r128219 landed, it added a reference to llint_op_get_array_length, and this broke the C++ llint. This demonstrates that the above approach is too fragile in practice. So, I will refactor the FOR_EACH_OPCODE_ID() macro to create a separate FOR_EACH_CORE_OPCODE_ID() macro. This FOR_EACH_CORE_OPCODE_ID() macro will be used to automatically declare the llint opcode aliases that the C++ llint needs.
Created attachment 163520 [details]
Attachment 163520 [details] did not pass style-queue:
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
The style checker will complain about indented code in the namespace. This is needed to stay consistent with existing code in Opcode.h. To resolve this complaint would mean making the changed code inconsistent with the rest, or go on an unindent spree that will make the diff hard to read. It's better off the way it is right now.
*** Bug 96509 has been marked as a duplicate of this bug. ***
Comment on attachment 163520 [details]
Clearing flags on attachment: 163520
Committed r128369: <http://trac.webkit.org/changeset/128369>
All reviewed patches have been landed. Closing bug.