Bug 96445 - Introduce SelectorCheckingEffects.
Summary: Introduce SelectorCheckingEffects.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 96425
  Show dependency treegraph
 
Reported: 2012-09-11 16:08 PDT by Dimitri Glazkov (Google)
Modified: 2022-02-27 23:55 PST (History)
3 users (show)

See Also:


Attachments
Patch (14.70 KB, patch)
2012-09-11 16:11 PDT, Dimitri Glazkov (Google)
koivisto: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2012-09-11 16:08:21 PDT
Introduce StyleCheckingEffects.
Comment 1 Dimitri Glazkov (Google) 2012-09-11 16:11:26 PDT
Created attachment 163472 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2012-09-11 16:11:52 PDT
This
Comment 3 Dimitri Glazkov (Google) 2012-09-11 16:12:26 PDT
This is based off the patch on bug 96425. Expect purple until it lands.
Comment 4 Eric Seidel (no email) 2012-09-11 16:22:13 PDT
Comment on attachment 163472 [details]
Patch

Effects is kinda an odd name, but this looks fine.  I don't have any better suggestions. :)
Comment 5 Antti Koivisto 2012-09-12 06:03:50 PDT
Comment on attachment 163472 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163472&action=review

> Source/WebCore/css/SelectorChecker.h:80
> +    // Some information can't be determined until the selector checking runs.
> +    // This struct captures that information.
> +    struct SelectorCheckingEffects {

Name "Effects" doesn't make sense to me here. Wouldn't it be better to capture all return values (including SelectorMatch) to something like SelectorCheckResult?

r- for now.
Comment 6 Dimitri Glazkov (Google) 2012-09-12 09:12:16 PDT
(In reply to comment #5)
> (From update of attachment 163472 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=163472&action=review
> 
> > Source/WebCore/css/SelectorChecker.h:80
> > +    // Some information can't be determined until the selector checking runs.
> > +    // This struct captures that information.
> > +    struct SelectorCheckingEffects {
> 
> Name "Effects" doesn't make sense to me here. Wouldn't it be better to capture all return values (including SelectorMatch) to something like SelectorCheckResult?

Yup. Sounds good.

> 
> r- for now.