RESOLVED FIXED Bug 96425
Remove transient state regarding uknown pseudoelements from SelectorChecker. 
https://bugs.webkit.org/show_bug.cgi?id=96425
Summary Remove transient state regarding uknown pseudoelements from SelectorChecker.
Dimitri Glazkov (Google)
Reported 2012-09-11 14:29:35 PDT
Remove transient state regarding uknown pseudoelements from SelectorChecker.
Attachments
Patch (14.22 KB, patch)
2012-09-11 14:35 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.21 KB, patch)
2012-09-12 09:23 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2012-09-11 14:35:38 PDT
Created attachment 163440 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2012-09-11 14:39:21 PDT
I wonder if I should add SelectorCheckingResult that's returned by checkSelector and stash stuff in there instead of using by-ref parameters.
Eric Seidel (no email)
Comment 3 2012-09-11 14:51:44 PDT
Comment on attachment 163440 [details] Patch I think this is going to end up as part of some sort of CheckRequest object, insetad of a separate bool :)
Eric Seidel (no email)
Comment 4 2012-09-11 14:52:56 PDT
Comment on attachment 163440 [details] Patch But this is probably a step in teh right direction.
Dimitri Glazkov (Google)
Comment 5 2012-09-11 15:24:26 PDT
(In reply to comment #3) > (From update of attachment 163440 [details]) > I think this is going to end up as part of some sort of CheckRequest object, insetad of a separate bool :) CheckRequest or CheckResponse? Or maybe SelectorCheckingResults?
Eric Seidel (no email)
Comment 6 2012-09-11 15:26:11 PDT
They all sound good to me. :)
Dimitri Glazkov (Google)
Comment 7 2012-09-11 15:40:43 PDT
Comment on attachment 163440 [details] Patch I will do this in the next patch.
WebKit Review Bot
Comment 8 2012-09-11 16:20:57 PDT
Comment on attachment 163440 [details] Patch Rejecting attachment 163440 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: olved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 9 refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13820554
Dimitri Glazkov (Google)
Comment 9 2012-09-12 09:23:37 PDT
Created attachment 163647 [details] Patch for landing
WebKit Review Bot
Comment 10 2012-09-12 09:50:11 PDT
Comment on attachment 163647 [details] Patch for landing Clearing flags on attachment: 163647 Committed r128329: <http://trac.webkit.org/changeset/128329>
WebKit Review Bot
Comment 11 2012-09-12 09:50:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.