96175 – JSC: Implement llint support on the Windows port

RESOLVED FIXED96175

JSC: Implement llint support on the Windows port

https://bugs.webkit.org/show_bug.cgi?id=96175

Summary JSC: Implement llint support on the Windows port

Mark Lam

Reported 2012-09-07 22:03:19 PDT

Need llint support on the Windows port.

Attachments
Work in progress 1: Seems to build LLIntAssembly.h successfully. (50.49 KB, patch) 2012-09-07 22:27 PDT, Mark Lam	no flags	Details Formatted Diff Diff
Example of a generated LLIntAssembly.h for the llint C++ backend. (452.72 KB, application/octet-stream) 2012-09-07 22:51 PDT, Mark Lam	no flags	Details
Example of a generated LLIntDesiredOffsets.h. (3.59 MB, application/octet-stream) 2012-09-07 22:53 PDT, Mark Lam	no flags	Details
Windows port seems to build now. Let's try it on the EWS. (62.29 KB, patch) 2012-09-08 10:26 PDT, Mark Lam	webkit-ews: commit-queue-	Details Formatted Diff Diff
A much cleaner patch that forces the llint C++ backend only on the Windows port. (30.60 KB, patch) 2012-09-11 16:34 PDT, Mark Lam	buildbot: commit-queue-	Details Formatted Diff Diff
work in progress 4: fixed the 2 issues that broke the last ews try. (46.20 KB, patch) 2012-09-11 21:34 PDT, Mark Lam	no flags	Details Formatted Diff Diff
work in progress 5: cleaned up, and svn up'ed. (28.61 KB, patch) 2012-09-15 23:51 PDT, Mark Lam	no flags	Details Formatted Diff Diff
Fix. (30.73 KB, patch) 2012-09-16 23:36 PDT, Mark Lam	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2012-09-07 22:27:39 PDT

Created attachment 162941 [details] Work in progress 1: Seems to build LLIntAssembly.h successfully. Unfortunately, LowLevelInterpreter.cpp doesn't build on MSVC. Will need to investigate that next.

Mark Lam

Comment 2 2012-09-07 22:51:43 PDT

Created attachment 162944 [details] Example of a generated LLIntAssembly.h for the llint C++ backend.

Mark Lam

Comment 3 2012-09-07 22:53:18 PDT

Created attachment 162945 [details] Example of a generated LLIntDesiredOffsets.h.

Mark Lam

Comment 4 2012-09-08 10:26:42 PDT

Created attachment 162960 [details] Windows port seems to build now. Let's try it on the EWS.

WebKit Review Bot

Comment 5 2012-09-08 10:30:07 PDT

Attachment 162960 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WTF/wtf/UnusedParam.h:40: Missing spaces around && [whitespace/operators] [3] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 6 2012-09-08 10:44:39 PDT

Comment on attachment 162960 [details] Windows port seems to build now. Let's try it on the EWS. Attachment 162960 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13785997

Early Warning System Bot

Comment 7