Bug 96175 – JSC: Implement llint support on the Windows port

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Need llint support on the Windows port.

[Mark Lam]

Created attachment 162941 [details]
Work in progress 1: Seems to build LLIntAssembly.h successfully.

Unfortunately, LowLevelInterpreter.cpp doesn't build on MSVC.  Will need to investigate that next.

[Mark Lam]

Created attachment 162944 [details]
Example of a generated LLIntAssembly.h for the llint C++ backend.

[Mark Lam]

Created attachment 162945 [details]
Example of a generated LLIntDesiredOffsets.h.

[Mark Lam]

Created attachment 162960 [details]
Windows port seems to build now. Let's try it on the EWS.

[WebKit Review Bot]

Attachment 162960 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/WTF/wtf/UnusedParam.h:40:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 162960 [details]
Windows port seems to build now. Let's try it on the EWS.

Attachment 162960 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13785997

[Early Warning System Bot]

Comment on attachment 162960 [details]
Windows port seems to build now. Let's try it on the EWS.

Attachment 162960 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13802124

[Build Bot]

Comment on attachment 162960 [details]
Windows port seems to build now. Let's try it on the EWS.

Attachment 162960 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13798252

[Gyuyoung Kim]

Comment on attachment 162960 [details]
Windows port seems to build now. Let's try it on the EWS.

Attachment 162960 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13800230

[kov's GTK+ EWS bot]

Comment on attachment 162960 [details]
Windows port seems to build now. Let's try it on the EWS.

Attachment 162960 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13787000

[Mark Lam]

Created attachment 163477 [details]
A much cleaner patch that forces the llint C++ backend only on the Windows port.

Let's test this against the ews bots.

[Build Bot]

Comment on attachment 163477 [details]
A much cleaner patch that forces the llint C++ backend only on the Windows port.

Attachment 163477 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13811769

[kov's GTK+ EWS bot]

Comment on attachment 163477 [details]
A much cleaner patch that forces the llint C++ backend only on the Windows port.

Attachment 163477 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13806971

[Mark Lam]

Created attachment 163514 [details]
work in progress 4: fixed the 2 issues that broke the last ews try.

[WebKit Review Bot]

Attachment 163514 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/JavaScriptCore.vcpro..." exit_code: 1
Source/JavaScriptCore/bytecode/Opcode.h:42:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Lam]

Created attachment 164310 [details]
work in progress 5: cleaned up, and svn up'ed.

[Mark Lam]

Created attachment 164344 [details]
Fix.

[Geoffrey Garen]

Comment on attachment 164344 [details]
Fix.

View in context: https://bugs.webkit.org/attachment.cgi?id=164344&action=review

r=me

> Source/JavaScriptCore/JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcproj:12
> +		<Platform
> +			Name="Win32"
> +		/>

Does this specifically exclude Win64?

[Mark Lam]

(In reply to comment #18)
> > Source/JavaScriptCore/JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcproj:12
> > +		<Platform
> > +			Name="Win32"
> > +		/>
> 
> Does this specifically exclude Win64?

I think yes.  But I didn't add this.  It is simply inherited (copied from) from the rest of the project.  This may have to be revised when/if Win64 support is added.

[Mark Lam]

Committed r128771: <http://trac.webkit.org/changeset/128771>.

[Csaba Osztrogonác]

(In reply to comment #20)
> Committed r128771: <http://trac.webkit.org/changeset/128771>.

It broke my git.webkit.org repository:

$ git status
# On branch master
# Changed but not updated:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#       modified:   Source/JavaScriptCore/JavaScriptCore.vcproj/LLIntAssembly/LLIntAssembly.vcproj
#       modified:   Source/JavaScriptCore/JavaScriptCore.vcproj/LLIntDesiredOffsets/LLIntDesiredOffsets.vcproj
#       modified:   Source/JavaScriptCore/JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcproj
#
no changes added to commit (use "git add" and/or "git commit -a")

git checkout ... or git reset --hard HEAD can't fix it.
Have you got any idea what is this problem?

[Csaba Osztrogonác]

... and it killed Qt,GTK,EFL EWS bots with same error.
I cc-ed other guys, maybe you any idea what happens.

[Csaba Osztrogonác]

I think I got the problem. The old vcproj files has the following svn property:
"Property svn:eol-style set to native", but the problematic 3 files don't.

[Mark Lam]

(In reply to comment #23)
> I think I got the problem. The old vcproj files has the following svn property:
> "Property svn:eol-style set to native", but the problematic 3 files don't.

OK, I'll undo the commit, and re-apply to see if that helps.

[Csaba Osztrogonác]

I filed a new bug report to find a general fix for this problem - https://bugs.webkit.org/show_bug.cgi?id=96934

[Mark Lam]

(In reply to comment #24)
> (In reply to comment #23)
> > I think I got the problem. The old vcproj files has the following svn property:
> > "Property svn:eol-style set to native", but the problematic 3 files don't.
> 
> OK, I'll undo the commit, and re-apply to see if that helps.

Set svn:eol-style to native in r128777: <http://trac.webkit.org/changeset/128777>.

[Brent Fulgham]

This change broke the WinCairo build bot.  I'll try to get it sorted out in the morning.

[Mark Lam]

(In reply to comment #27)
> This change broke the WinCairo build bot.  I'll try to get it sorted out in the morning.

This is being fixed in <https://bugs.webkit.org/show_bug.cgi?id=96992>.