RESOLVED FIXED 96992
JSC: Fix for WinCairo builds 
https://bugs.webkit.org/show_bug.cgi?id=96992
Summary JSC: Fix for WinCairo builds
Mark Lam
Reported 2012-09-18 01:04:17 PDT
When the llint vcproj files were added, I wasn't aware that the rest of the other vcproj build targets are in use. This fix sets up the build targets in LLIntDesiredOffsets.vcproj, LLIntOffsetsExtractor.vcproj, and LLIntAssembly.vcproj to match those in jsc.vcproj.
Attachments
Fix. (30.95 KB, patch)
2012-09-18 01:13 PDT, Mark Lam 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2012-09-18 01:13:11 PDT
Created attachment 164511 [details] Fix.
Filip Pizlo
Comment 2 2012-09-18 01:31:09 PDT
Comment on attachment 164511 [details] Fix. rs=me
Mark Lam
Comment 3 2012-09-18 01:41:22 PDT
Committed fix in r128860: <http://trac.webkit.org/changeset/128860>.
Mark Lam
Comment 4 2012-09-18 09:58:40 PDT
The fix failed.
Mark Lam
Comment 5 2012-09-18 10:01:19 PDT
The wincairo flavor builds fine for me locally.
Mark Lam
Comment 6 2012-09-18 22:41:39 PDT
The fix is effective. A clean build was needed to clear the build errors: http://build.webkit.org/builders/WinCairo%20Release/builds/15552 http://build.webkit.org/builders/WinCairo%20Release/builds/15552/steps/jscore-test/logs/stdio Closing as fixed.
Note You need to log in before you can comment on or make changes to this bug.