Bug 96992 - JSC: Fix for WinCairo builds
Summary: JSC: Fix for WinCairo builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-18 01:04 PDT by Mark Lam
Modified: 2012-09-18 22:41 PDT (History)
1 user (show)

See Also:

Attachments
Fix. (30.95 KB, patch)
2012-09-18 01:13 PDT, Mark Lam 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2012-09-18 01:04:17 PDT 
When the llint vcproj files were added, I wasn't aware that the rest of the other vcproj build targets are in use.  This fix sets up the build targets in LLIntDesiredOffsets.vcproj, LLIntOffsetsExtractor.vcproj, and LLIntAssembly.vcproj to match those in jsc.vcproj.
Comment 1 Mark Lam 2012-09-18 01:13:11 PDT 
Created attachment 164511 [details]
Fix.
Comment 2 Filip Pizlo 2012-09-18 01:31:09 PDT 
Comment on attachment 164511 [details]
Fix.

rs=me
Comment 3 Mark Lam 2012-09-18 01:41:22 PDT 
Committed fix in r128860: <http://trac.webkit.org/changeset/128860>.
Comment 4 Mark Lam 2012-09-18 09:58:40 PDT 
The fix failed.
Comment 5 Mark Lam 2012-09-18 10:01:19 PDT 
The wincairo flavor builds fine for me locally.
Comment 6 Mark Lam 2012-09-18 22:41:39 PDT 
The fix is effective.  A clean build was needed to clear the build errors:
http://build.webkit.org/builders/WinCairo%20Release/builds/15552
http://build.webkit.org/builders/WinCairo%20Release/builds/15552/steps/jscore-test/logs/stdio

Closing as fixed.