Bug 96065 – REGRESSION(127810): It broke inspector/debugger/debugger-expand-scope.html

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

Steps of fixing https://bugs.webkit.org/show_bug.cgi?id=95659 :
- https://trac.webkit.org/changeset/127698 (with updating expected txt)
- https://trac.webkit.org/changeset/127774 (reverting r127698 without expected file)
- https://trac.webkit.org/changeset/127808 (reverting the expected file change too)
- https://trac.webkit.org/changeset/127810 (fixed patch without expected update)
- https://trac.webkit.org/changeset/127814 (update the expected file - reverting 127808)

The updated expected file passed on Qt after r127698, but if fails 
after r127814. So it needed updated with the first patch r127698, 
but it doesn't with the second patch r127810.

Could you check it, please? Now I don't have any idea if it is
a progression or a regression. I totally confused. :)


It fails on EFL,Qt and Mountail Lion now: (skipped on mac-lion)
----------------------------------------------------------------
--- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/debugger-expand-scope-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/debugger-expand-scope-actual.txt 
@@ -19,8 +19,6 @@
     arguments: Arguments[1]
     makeClosureLocalVar: "local.TextParam"
     n: "TextParam"
-WindowWith Block
-    makeClosure: function makeClosure(n) {
 WindowGlobal
     <section collapsed>
 Script execution resumed.

[Csaba Osztrogonác]

I reverted the expected file change to paint the bots green - https://trac.webkit.org/changeset/127827

Please check if it is proper fix or not.

[Tim Horton]

Heh, sorry for the noise :\ Hopefully Geoff will know what's really up.

[Geoffrey Garen]

That's the right change.

Sorry, I thought Tim was in the process of making that change when I landed.

[Tim Horton]

(In reply to comment #3)
> That's the right change.
> 
> Sorry, I thought Tim was in the process of making that change when I landed.

I did! And then I un-made it when you landed :\