[chromium] Add a customized copy() method to CCRenderPassDrawQuad
Created attachment 162283 [details] Patch
Comment on attachment 162283 [details] Patch Is there a reason you can't just call setRenderPassId() post-copy?
I think we should avoid setters on these classes. Instead it would construct a new CCRPDQ via constructor, giving it all the same values as the original except the ID. The copy method makes this simpler and also avoids API churn, and just looked better in the caller code. if (!isRenderPassQuad) newQuad = quad->copy(); else { castQuad = CCRPDQ::materialCast(quad); newQuad = CCRPDQ::create(castQuad->foo(), castQuad->bar(), castQuad->baz(), ....); } VS if (!isRenderPassQuad) newQuad = quad->copy(); else newQuad = CCRPDQ::materialCast(quad)->copy(newId);
Comment on attachment 162283 [details] Patch Ok, I am mildly convinced. R=me, assuming you get a clean EWS or CQ before submitting.
Comment on attachment 162283 [details] Patch Clearing flags on attachment: 162283 Committed r127756: <http://trac.webkit.org/changeset/127756>
All reviewed patches have been landed. Closing bug.