Bug 95374 - [chromium] Add a copy() method to CCDrawQuad and CCSharedQuadState
Summary: [chromium] Add a copy() method to CCDrawQuad and CCSharedQuadState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks: 94145 95871
  Show dependency treegraph
 
Reported: 2012-08-29 13:48 PDT by Dana Jansens
Modified: 2012-09-05 23:26 PDT (History)
7 users (show)

See Also:


Attachments
Patch (18.81 KB, patch)
2012-08-29 15:19 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff
Patch for landing (18.76 KB, patch)
2012-09-05 12:47 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-08-29 13:48:16 PDT
[chromium] Add a copy() method to CCDrawQuad and CCSharedQuadState
Comment 1 Dana Jansens 2012-08-29 15:19:31 PDT
Created attachment 161329 [details]
Patch
Comment 2 Adrienne Walker 2012-09-05 09:14:14 PDT
Comment on attachment 161329 [details]
Patch

R=me.
Comment 3 WebKit Review Bot 2012-09-05 11:11:58 PDT
Comment on attachment 161329 [details]
Patch

Rejecting attachment 161329 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
/WebKit/chromium/tests/CCDrawQuadTest.cpp: In member function 'virtual void<unnamed>::CCDrawQuadTest_copyTileDrawQuad_Test::TestBody()':
Source/WebKit/chromium/tests/CCDrawQuadTest.cpp:273: error: 'EXPECT_INT_RECT_EQ' was not declared in this scope
  CXX(target) out/Release/obj.target/webkit_unit_tests/Source/WebKit/chromium/tests/CCLayerImplTest.o
make: *** [out/Release/obj.target/webkit_unit_tests/Source/WebKit/chromium/tests/CCDrawQuadTest.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/13746955
Comment 4 James Robinson 2012-09-05 11:20:34 PDT
The macro you want is gone - use EXPECT_RECT_EQ().  I'm surprised EWS is green - methinks it didn't actually process the patch as rigorously as the bubble would imply.....
Comment 5 James Robinson 2012-09-05 11:20:47 PDT
Or perhaps it ran before that rename.
Comment 6 Dana Jansens 2012-09-05 12:35:10 PDT
(In reply to comment #4)
> The macro you want is gone - use EXPECT_RECT_EQ().  I'm surprised EWS is green - methinks it didn't actually process the patch as rigorously as the bubble would imply.....

Oh okay, thanks.
Comment 7 Dana Jansens 2012-09-05 12:47:17 PDT
Created attachment 162308 [details]
Patch for landing
Comment 8 WebKit Review Bot 2012-09-05 23:26:28 PDT
Comment on attachment 162308 [details]
Patch for landing

Clearing flags on attachment: 162308

Committed r127699: <http://trac.webkit.org/changeset/127699>
Comment 9 WebKit Review Bot 2012-09-05 23:26:32 PDT
All reviewed patches have been landed.  Closing bug.