Bug 95861 – [Chromium] Define new setSharedWorkerRepository function in preparation for removing WebKitPlatformSupport::sharedWorkerRepository()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Mark Pilgrim (Google)]

[Chromium] Define new setSharedWorkerRepository function in preparation for removing WebKitPlatformSupport::sharedWorkerRepository()

[Mark Pilgrim (Google)]

Created attachment 162265 [details]
Patch

[Mark Pilgrim (Google)]

*** Bug 94481 has been marked as a duplicate of this bug. ***

[Adam Barth]

Comment on attachment 162265 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162265&action=review

> Source/WebKit/chromium/src/SharedWorkerRepository.cpp:71
> +static void setSharedWorkerRepository(WebKit::WebSharedWorkerRepository* repository)

I'm not sure how Chromium patch will call this function given that it's not exposed in any headers.

> Source/WebKit/chromium/src/SharedWorkerRepository.cpp:276
> +    repository = s_sharedWorkerRepository;
> +    if (!repository)
> +        repository = WebKit::webKitPlatformSupport()->sharedWorkerRepository();

I would have made this into a static helper function because you've repeated it several times.

[Mark Pilgrim (Google)]

Created attachment 162507 [details]
Patch

[Mark Pilgrim (Google)]

Nits addressed, WebKit.h export added.

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adam Barth]

Comment on attachment 162507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162507&action=review

> Source/WebKit/chromium/public/WebKit.h:34
> +#include "WebSharedWorkerRepository.h"

You don't need this #include.  You can just forward declare WebSharedWorkerRepository

> Source/WebKit/chromium/src/SharedWorkerRepository.cpp:65
> +void setSharedWorkerRepository(WebSharedWorkerRepository* repository)

Maybe we should put this function in WebSharedWorkerRepository.h rather than WebKit.h?

[Mark Pilgrim (Google)]

Created attachment 163162 [details]
Patch

[Mark Pilgrim (Google)]

Comment on attachment 163162 [details]
Patch

Nits addressed, moved everything out of Webkit.h and into more appropriate header files.

[Adam Barth]

Thanks!

[WebKit Review Bot]

Comment on attachment 163162 [details]
Patch

Clearing flags on attachment: 163162

Committed r128087: <http://trac.webkit.org/changeset/128087>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.