Bug 95760 - [CSS Shaders] Update custom filter tests to use the new security model
Summary: [CSS Shaders] Update custom filter tests to use the new security model
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Max Vujovic
URL:
Keywords:
Depends on:
Blocks: 71392 93871
  Show dependency treegraph
 
Reported: 2012-09-04 10:47 PDT by Max Vujovic
Modified: 2012-09-05 11:26 PDT (History)
3 users (show)

See Also:


Attachments
Patch (319.32 KB, patch)
2012-09-04 16:22 PDT, Max Vujovic
no flags Details | Formatted Diff | Diff
Patch (319.60 KB, patch)
2012-09-05 00:13 PDT, Max Vujovic
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Max Vujovic 2012-09-04 10:47:46 PDT
Currently, most of the custom filter tests sample the DOM element texture (u_texture) and write to gl_FragColor. Instead, the tests should not sample the DOM element texture and write to css_MixColor. This will enable us to remove direct DOM element texture access in bug 93871.
Comment 1 Max Vujovic 2012-09-04 16:22:27 PDT
Created attachment 162126 [details]
Patch
Comment 2 Alexandru Chiculita 2012-09-04 17:02:19 PDT
Comment on attachment 162126 [details]
Patch

Looks good to me!
Comment 3 Max Vujovic 2012-09-05 00:13:39 PDT
Created attachment 162174 [details]
Patch

Updated chromium TestExpectations. Need baselines for cr-linux, cr-win.
Comment 4 Max Vujovic 2012-09-05 08:40:48 PDT
Comment on attachment 162174 [details]
Patch

Bots look good. Setting r?, cq?.
Comment 5 WebKit Review Bot 2012-09-05 11:26:37 PDT
Comment on attachment 162174 [details]
Patch

Clearing flags on attachment: 162174

Committed r127615: <http://trac.webkit.org/changeset/127615>
Comment 6 WebKit Review Bot 2012-09-05 11:26:40 PDT
All reviewed patches have been landed.  Closing bug.