Bug 95730 – [Qt][Win] Fix IDL dependency generation correctly

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jonathan Liu]

IDL dependency generation is still not working after https://bugs.webkit.org/show_bug.cgi?id=88304.
This is because spaces added after the filename in an echo command end up being added to the file (e.g. "echo test>> test.txt " would add a space at the end of the line in test.txt).

[Jonathan Liu]

Created attachment 162006 [details]
Patch

[Csaba Osztrogonác]

The trailing whitespace is ugly at the end of the command.

But why does it cause problem for you? Windows simple 
ignores these trailing whitespaces.

[Jonathan Liu]

It doesn't ignore the trailing whitespace at least on Windows 7. Try it from a command prompt: type "echo test>> test.txt " (without the quotes and with a space at the end) and press enter. Open test.txt and you will see a trailing space after "test".

[Csaba Osztrogonác]

(In reply to comment #3)
> It doesn't ignore the trailing whitespace at least on Windows 7. Try it from a command prompt: type "echo test>> test.txt " (without the quotes and with a space at the end) and press enter. Open test.txt and you will see a trailing space after "test".

OMG, you're right, same result on Win XP, crazy Windows' cmd.exe :)

[Csaba Osztrogonác]

Comment on attachment 162006 [details]
Patch

r=me

[Jonathan Liu]

An alternative syntax for echo to a file is:
echo>>test.txt blah blah blah

That's why it adds the space.

[WebKit Review Bot]

Comment on attachment 162006 [details]
Patch

Clearing flags on attachment: 162006

Committed r127467: <http://trac.webkit.org/changeset/127467>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.