Bug 88304 – [Qt][Win] Fix IDL dependency generation

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

Now WebCore/bindings/scripts/preprocess-idls.pl works incorrectly on Qt Windows, 
because the generated WebKitBuild/Release/Source/WebCore/generated/idl_files.tmp
contains trailing whitespaces after filenames. It is generated by "GENERATOR 0"
in WebCore/DerivedSources.pri by simple echo.

[Csaba Osztrogonác]

Created attachment 145771 [details]
Patch

[Csaba Osztrogonác]

(In reply to comment #1)
> Created an attachment (id=145771) [details]
> Patch

(In reply to comment #1)
> Created an attachment (id=145771) [details]
> Patch

WebCore/bindings/scripts/preprocess-idls.pl can't handle "foo.idl " filenames, so we don't dump "foo.idl " names, but "foo.idl" names to idl_files.tmp.

The bug was caused by echo's different behaviour on Linux and Windows:
Linux's echo trims trailing whitespaces, but Windows' echo preserve all of them.

[Tor Arne Vestbø]

Comment on attachment 145771 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145771&action=review

> Source/WebCore/DerivedSources.pri:685
> +    # We need "$$binding " instead of "$$binding", because Windows' echo writes trailing whitespaces. (http://wkb.ug/88304)

Isn't the case that we need "$$binding", not "$$binding " with trailing space?

> Source/WebCore/DerivedSources.pri:686
> +    preprocessIdls.commands += echo $$binding>> $$IDL_FILES_TMP $$EOC

Can this be done by quoting instead?

[Csaba Osztrogonác]

(In reply to comment #3)
> (From update of attachment 145771 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145771&action=review
> 
> > Source/WebCore/DerivedSources.pri:685
> > +    # We need "$$binding " instead of "$$binding", because Windows' echo writes trailing whitespaces. (http://wkb.ug/88304)
> 
> Isn't the case that we need "$$binding", not "$$binding " with trailing space?

Good point. :)
 
> > Source/WebCore/DerivedSources.pri:686
> > +    preprocessIdls.commands += echo $$binding>> $$IDL_FILES_TMP $$EOC
> 
> Can this be done by quoting instead?
Unfortunately no.

echo "xxx" >1.txt --> 1.txt:"xxx" + the trailing whitespace 
(similar to ' instead of ")

[Csaba Osztrogonác]

Created attachment 145776 [details]
Patch

Fixed typo

[WebKit Review Bot]

Comment on attachment 145776 [details]
Patch

Clearing flags on attachment: 145776

Committed r119490: <http://trac.webkit.org/changeset/119490>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.