Bug 88304 - [Qt][Win] Fix IDL dependency generation
: [Qt][Win] Fix IDL dependency generation
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: All All
: P1 Blocker
Assigned To:
:
: Qt, QtTriaged
:
: 88300
  Show dependency treegraph
 
Reported: 2012-06-05 01:08 PST by
Modified: 2012-06-05 08:26 PST (History)


Attachments
Patch (1.52 KB, patch)
2012-06-05 05:51 PST, Csaba Osztrogonác
no flags Review Patch | Details | Formatted Diff | Diff
Patch (1.52 KB, patch)
2012-06-05 06:10 PST, Csaba Osztrogonác
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-06-05 01:08:02 PST
Now WebCore/bindings/scripts/preprocess-idls.pl works incorrectly on Qt Windows, 
because the generated WebKitBuild/Release/Source/WebCore/generated/idl_files.tmp
contains trailing whitespaces after filenames. It is generated by "GENERATOR 0"
in WebCore/DerivedSources.pri by simple echo.
------- Comment #1 From 2012-06-05 05:51:03 PST -------
Created an attachment (id=145771) [details]
Patch
------- Comment #2 From 2012-06-05 05:55:59 PST -------
(In reply to comment #1)
> Created an attachment (id=145771) [details] [details]
> Patch

(In reply to comment #1)
> Created an attachment (id=145771) [details] [details]
> Patch

WebCore/bindings/scripts/preprocess-idls.pl can't handle "foo.idl " filenames, so we don't dump "foo.idl " names, but "foo.idl" names to idl_files.tmp.

The bug was caused by echo's different behaviour on Linux and Windows:
Linux's echo trims trailing whitespaces, but Windows' echo preserve all of them.
------- Comment #3 From 2012-06-05 06:01:25 PST -------
(From update of attachment 145771 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=145771&action=review

> Source/WebCore/DerivedSources.pri:685
> +    # We need "$$binding " instead of "$$binding", because Windows' echo writes trailing whitespaces. (http://wkb.ug/88304)

Isn't the case that we need "$$binding", not "$$binding " with trailing space?

> Source/WebCore/DerivedSources.pri:686
> +    preprocessIdls.commands += echo $$binding>> $$IDL_FILES_TMP $$EOC

Can this be done by quoting instead?
------- Comment #4 From 2012-06-05 06:08:29 PST -------
(In reply to comment #3)
> (From update of attachment 145771 [details] [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145771&action=review
> 
> > Source/WebCore/DerivedSources.pri:685
> > +    # We need "$$binding " instead of "$$binding", because Windows' echo writes trailing whitespaces. (http://wkb.ug/88304)
> 
> Isn't the case that we need "$$binding", not "$$binding " with trailing space?

Good point. :)

> > Source/WebCore/DerivedSources.pri:686
> > +    preprocessIdls.commands += echo $$binding>> $$IDL_FILES_TMP $$EOC
> 
> Can this be done by quoting instead?
Unfortunately no.

echo "xxx" >1.txt --> 1.txt:"xxx" + the trailing whitespace 
(similar to ' instead of ")
------- Comment #5 From 2012-06-05 06:10:34 PST -------
Created an attachment (id=145776) [details]
Patch

Fixed typo
------- Comment #6 From 2012-06-05 08:26:23 PST -------
(From update of attachment 145776 [details])
Clearing flags on attachment: 145776

Committed r119490: <http://trac.webkit.org/changeset/119490>
------- Comment #7 From 2012-06-05 08:26:35 PST -------
All reviewed patches have been landed.  Closing bug.