RESOLVED INVALID Bug 95599
[Chromium-Android] Remove test_expectations_android.txt 
https://bugs.webkit.org/show_bug.cgi?id=95599
Summary [Chromium-Android] Remove test_expectations_android.txt
Xianzhu Wang
Reported 2012-08-31 12:38:40 PDT
LayoutTests/platform/chromium/test_expectations_android.txt is used to store Android-specific expectations. It's empty in upstream. As we have upstreamed most of the contents in downstream test_expectations_android.txt, it's time to remove it.
Attachments
Patch (3.19 KB, patch)
2012-08-31 12:48 PDT, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xianzhu Wang
Comment 1 2012-08-31 12:41:38 PDT
In downstream we'll keep test_expectations_android.txt for some time and use --additional-expectations to include the file.
Xianzhu Wang
Comment 2 2012-08-31 12:48:38 PDT
Created attachment 161754 [details] Patch
Dirk Pranke
Comment 3 2012-08-31 13:19:25 PDT
alternatively, you could leave it in, upstream it, and add it to the end of the expectations_files() list (so it was included in the cascade) and then move your skipped tests there from skipped_layout_tests().
Dirk Pranke
Comment 4 2012-08-31 13:21:22 PDT
(In reply to comment #3) > alternatively, you could leave it in, upstream it, and add it to the end of the expectations_files() list (so it was included in the cascade) and then move your skipped tests there from skipped_layout_tests(). Whoops, of course you already have it in expectations_files(). So, you could leave it there and moved the skipped tests there. I'd probably recommend that as, as much as we're not used to having an additional expectations file for android, we're used to having a list of tests embedded in the code even less. Or we could just add an ANDROID modifier to the TestExpectations syntax and move those lines into the main file.
Dirk Pranke
Comment 5 2012-08-31 13:22:47 PDT
(I r+'ed the change so it's up to you ... whichever you want to do).
Xianzhu Wang
Comment 6 2012-08-31 13:53:15 PDT
(In reply to comment #5) > (I r+'ed the change so it's up to you ... whichever you want to do). Thanks for review. Our goal is to upstream all contents in test_expectations_android.txt into TestExpectations, so I prefer to remove it from upstream. Will only submit after downstream change (using --additional-expectations in downstream buildbot script) is ready. The directories hard-coded in skipped_layout_tests() doesn't look good. I tried to put them in TestExpectations, but it's not easy to skip whole directories because in TestExpectations there are many existing rules of individual tests under the directories. Filed bug 95605.
Xianzhu Wang
Comment 7 2012-08-31 14:43:13 PDT
Using the method in bug 95605, abandon this one because we want to keep test_expectations_android.txt to skip the whole directories.
Adam Barth
Comment 8 2012-09-01 00:56:12 PDT
Comment on attachment 161754 [details] Patch That's exciting!
Adam Barth
Comment 9 2012-09-01 00:58:10 PDT
(In reply to comment #8) > (From update of attachment 161754 [details]) > That's exciting! Oh, I guess this didn't land.
Xianzhu Wang
Comment 10 2012-09-01 11:59:43 PDT
(In reply to comment #9) > (In reply to comment #8) > > (From update of attachment 161754 [details] [details]) > > That's exciting! > > Oh, I guess this didn't land. Yeah, it's also exciting to keep only a minimal platform/chromium-android/TestExpectations (bug 95605) :)
Note You need to log in before you can comment on or make changes to this bug.